From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09AA9C54E49 for ; Mon, 26 Feb 2024 09:26:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.685383.1065982 (Exim 4.92) (envelope-from ) id 1reXG3-0004fL-GP; Mon, 26 Feb 2024 09:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 685383.1065982; Mon, 26 Feb 2024 09:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1reXG3-0004fE-Dl; Mon, 26 Feb 2024 09:26:47 +0000 Received: by outflank-mailman (input) for mailman id 685383; Mon, 26 Feb 2024 09:26:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1reXG2-0004f8-4q for xen-devel@lists.xenproject.org; Mon, 26 Feb 2024 09:26:46 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2858ee9c-d489-11ee-8a58-1f161083a0e0; Mon, 26 Feb 2024 10:26:44 +0100 (CET) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-564fd9eea75so3394075a12.3 for ; Mon, 26 Feb 2024 01:26:44 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id n9-20020a056402060900b0056200715130sm2181807edv.54.2024.02.26.01.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 01:26:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2858ee9c-d489-11ee-8a58-1f161083a0e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708939604; x=1709544404; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8GNOaXDjZBzAVrce0EwOuJ4HRtW79oEeKI7dXw8Ja/4=; b=RV5F9IVc76QjMdRlZNOHtvTKJtu8zRANdTjaNBlt3GOYQwSEwnq+RGAYk/LDvu63H9 E9GoUFJsMLP2oxDe/GSdt+Dx9ngqdsPBOqNqhmAadFkkvrPHv3my9AfJEyTZRWYqjBSj 78NhYrIt0mlgRhOfNG13Oj3Txfwa0PJr95MUbDAvQyigArmIsdv47eF7hPDTsQDNYLNF A0lVCMJURBUeWneHU7m0g9TUxQMTVM0dRL67SfTFaDeZshyOrxUUjnftR9tnCUcDLIPK CSe5LuG8D7YC8a7hUCoruaLTM0QtKJNpzXrBNRpri1iBUMiTl0492TcO0ly0T1gQV6Ol YNGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708939604; x=1709544404; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8GNOaXDjZBzAVrce0EwOuJ4HRtW79oEeKI7dXw8Ja/4=; b=IRSdN0+6OcXOpkj35/pqJryn/R9CnkJGs9j7UmWwis+83O9tT/DoBFYJnYfayJ8Lpk 13rjpYcE/+YNjim/Yn4mb913+URqCeh0IUiu14e54aUc5nwnfN38lB4LByRISaN4/Qeb Z5KbEh5ftKOcNbkAWlxAy5fGhwvR8osSRI8gWQVRyt8ugPNs7oiAMNoNzE9OP5DIlFTw pEunv5JmTTeAMVQB1dyGfkAyug/5zV9767wYQBNCLUDxAa3WChEPLBDTVn/TL6Jd/tT7 /HsyoTa1sCXuu4960GxoMFJjCVNERawlDe+k5POLaTMe2jsi8lCg8L77fSOUPrfst8u3 xXEA== X-Forwarded-Encrypted: i=1; AJvYcCUIgV5J+zmOJr82E1kqRgiznrsfcJ/1We3zpRBu+8+HCI0bguyJ+/0MNXPQ9E/2Yq1xxrtPlDVi5NMV/k6CDfxd8tv06SkmZeVnH///C6U= X-Gm-Message-State: AOJu0YyOfjxjDnhNHWgnxWWD5uZgpyCuo4S/09CM8RjQaqqxyezY+I5W 2fBtKvL2m3C7sv4THDWsyyUdgwyPvj3gZCrVnn+LD83q7LCqqvsce5iK5s3HDQ== X-Google-Smtp-Source: AGHT+IHxy+fJot7CzELNq79H1rPR0J93G+cewhckX4vNwrN2lmqJX6FHpx4uwW2PXy0r22ixyaZmdQ== X-Received: by 2002:a50:fc18:0:b0:563:d32f:5449 with SMTP id i24-20020a50fc18000000b00563d32f5449mr4231643edr.24.1708939604391; Mon, 26 Feb 2024 01:26:44 -0800 (PST) Message-ID: <19742e01-bc8d-41ed-a12c-b7f7bf57f642@suse.com> Date: Mon, 26 Feb 2024 10:26:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] xen/livepatch: fixes for the pre-apply / post-revert hooks Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Konrad Rzeszutek Wilk , Ross Lagerwall , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20231130142944.46322-1-roger.pau@citrix.com> <6143d253-1d5c-48c8-81b9-3652b21dd9c0@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26.02.2024 09:40, Roger Pau Monné wrote: > On Fri, Feb 23, 2024 at 11:48:10AM +0100, Jan Beulich wrote: >> On 30.11.2023 15:29, Roger Pau Monne wrote: >>> Hello, >>> >>> The follow series contain a misc of fixes mostly related to the usage of >>> the pre-apply / post-revert hooks. The norevert test is also fixed to >>> work as I think was expected. Finally both the no{apply,revert} >>> tests are fixed to build properly, as the files where previously >>> unhooked from the build system completely. >>> >>> I'm unsure how useful the apply and revert hooks really are, as without >>> calling the internal apply/revert functions the state of the payload >>> structure is quite likely inconsistent with the code expectations. >>> >>> Thanks, Roger. >>> >>> Roger Pau Monne (5): >>> xen/livepatch: register livepatch regions when loaded >>> xen/livepatch: search for symbols in all loaded payloads >>> xen/livepatch: fix norevert test attempt to open-code revert >>> xen/livepatch: fix norevert test hook setup typo >>> xen/livepatch: properly build the noapply and norevert tests >> >> With the R-b-s that have arrived, could you clarify in how far these >> can be committed out of order? > > All can be applied out of order, except for the last one, that's > "xen/livepatch: properly build the noapply and norevert tests" as > applying that will enable the tests in osstest, and those will fail > without all the previous adjustments. > > I was about to send v2 with the requested changes, but will wait for > you to commit 2/5 and 4/5. Except that patch 2 had 3 failing hunks, and not just fuzz in any of them. Which was too much for me to consider fixing up while committing. Jan