From: Heiko Stuebner <heiko@sntech.de>
To: kishon@ti.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-rockchip@lists.infradead.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH] phy: phy-rockchip-inno-usb2: add phy description for px30
Date: Thu, 31 Oct 2019 13:08:48 +0100 [thread overview]
Message-ID: <1974613.gpRaQal8Ma@phil> (raw)
In-Reply-To: <20190917082532.25479-1-heiko@sntech.de>
Hi Kishon,
Am Dienstag, 17. September 2019, 10:25:32 CET schrieb Heiko Stuebner:
> The px30 soc from Rockchip shares the same register description as
> the rk3328, so can re-use its definitions.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
could you pick this up as well please?
Thanks
Heiko
> ---
> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 1 +
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> index 00639baae74a..541f5298827c 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> @@ -2,6 +2,7 @@ ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK
>
> Required properties (phy (parent) node):
> - compatible : should be one of the listed compatibles:
> + * "rockchip,px30-usb2phy"
> * "rockchip,rk3228-usb2phy"
> * "rockchip,rk3328-usb2phy"
> * "rockchip,rk3366-usb2phy"
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index eae865ff312c..680cc0c8825c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1423,6 +1423,7 @@ static const struct rockchip_usb2phy_cfg rv1108_phy_cfgs[] = {
> };
>
> static const struct of_device_id rockchip_usb2phy_dt_match[] = {
> + { .compatible = "rockchip,px30-usb2phy", .data = &rk3328_phy_cfgs },
> { .compatible = "rockchip,rk3228-usb2phy", .data = &rk3228_phy_cfgs },
> { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs },
> { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs },
>
next prev parent reply other threads:[~2019-10-31 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 8:25 [PATCH] phy: phy-rockchip-inno-usb2: add phy description for px30 Heiko Stuebner
2019-09-30 22:49 ` Rob Herring
2019-09-30 22:49 ` Rob Herring
2019-10-31 12:08 ` Heiko Stuebner [this message]
2019-10-31 13:02 ` Kishon Vijay Abraham I
2019-10-31 13:02 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1974613.gpRaQal8Ma@phil \
--to=heiko@sntech.de \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.