From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 1/1] vnc, xen: write vnc address and password to xenstore Date: Thu, 3 Feb 2011 18:42:28 +0000 Message-ID: <19786.63252.555130.135185@mariner.uk.xensource.com> References: <1296584702-20138-1-git-send-email-ian.jackson@eu.citrix.com> <1296584702-20138-2-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 1/1] vnc, xen: write vnc address and password to xenstore"): > On Tue, 1 Feb 2011, Ian Jackson wrote: > > -void xenstore_write_vncport(int vnc_display); > > void xenstore_read_vncpasswd(int domid, char *pwbuf, size_t pwbuflen); > > void xenstore_write_vslots(char *vslots); > > > why did you add xenstore_write_vncinfo to qemu-common.h instead of > qemu-xen.h? Because qemu-xen.h isn't included by vnc.c, and when I tried to add it it all became a horrible doom of clashing symbols. This seemed like the best way out. Ian.