From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 5/6] libxl: vncviewer: unconditionally read
	listen port address and password
Date: Thu, 3 Feb 2011 18:44:18 +0000
Message-ID: <19786.63362.768811.378922@mariner.uk.xensource.com>
References: <1296584702-20138-1-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-2-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-3-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-4-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-5-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-6-git-send-email-ian.jackson@eu.citrix.com>
	<alpine.DEB.2.00.1102031234290.7277@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1102031234290.7277@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 5/6] libxl: vncviewer: unconditionally read listen port address and password"):
> On Tue, 1 Feb 2011, Ian Jackson wrote:
> > +
> > +    if ( autopass )
> > +        vnc_pass = libxl__xs_read(&gc, XBT_NULL,
> > +                                  libxl__sprintf(&gc,
> >                              "/local/domain/%d/console/vnc-pass", domid));
> > -    }
> >  
> 
> these changes don't follow the coding style (but even the original code
> does not).

Indeed.  I thought it best during the freeze to avoid making needless
changes, and also I didn't want to mix a code style cleanup with my
functional change.

Ian.