From: Thomas Monjalon <thomas@monjalon.net>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
Cc: stable@dpdk.org, "Dumitrescu,
Cristian" <cristian.dumitrescu@intel.com>,
David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6
Date: Thu, 04 Jul 2019 23:25:32 +0200 [thread overview]
Message-ID: <1979037.n3m16vrDg2@xps> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8B9040@IRSMSX108.ger.corp.intel.com>
02/07/2019 13:50, Dumitrescu, Cristian:
> From: David Marchand [mailto:david.marchand@redhat.com]
> On Tue, Jul 2, 2019 at 1:22 PM Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com<mailto:jananeex.m.parthasarathy@intel.com>> wrote:
> Unit test table_autotest results in segmentation fault.
> Crash occurs in test_table_lpm_ipv6_combined().
>
> Variable 'nht_pos0' used as array subscript is not initialized
> in rte_table_lpm_ipv6_entry_add(). It will not be assigned,
> if a rule does not exist.
>
> In such case a junk number or invalid array index might result in
> segmentation fault due to array out of bounds when
> lpm->nht_users is used with such invalid array index.
>
> Fix is to initialize the variables used for array subscript.
>
> Bugzilla ID: 285
>
> Fixes: d89a5bce1d ("lpm6: extend next hop field")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com<mailto:jananeex.m.parthasarathy@intel.com>>
[...]
> It fixes the segfault I saw, leaving the ack to the maintainer.
> Tested-by: David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-07-04 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 11:21 [dpdk-dev] [PATCH] lib/table: fix table autotest ut crashes in ipv6 Jananee Parthasarathy
2019-07-02 11:46 ` David Marchand
2019-07-02 11:50 ` Dumitrescu, Cristian
2019-07-04 21:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1979037.n3m16vrDg2@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.