From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E12CC5519F for ; Wed, 25 Nov 2020 09:36:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAA96206B5 for ; Wed, 25 Nov 2020 09:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="VkxU9j4B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAA96206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.37497.69884 (Exim 4.92) (envelope-from ) id 1khrDi-0008FX-Vr; Wed, 25 Nov 2020 09:36:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 37497.69884; Wed, 25 Nov 2020 09:36:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khrDi-0008FQ-Sv; Wed, 25 Nov 2020 09:36:14 +0000 Received: by outflank-mailman (input) for mailman id 37497; Wed, 25 Nov 2020 09:36:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khrDh-0008FL-4c for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 09:36:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c0d80d88-2568-4d52-8d74-6cb5bec0bd7d; Wed, 25 Nov 2020 09:36:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F054AC6A; Wed, 25 Nov 2020 09:36:11 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khrDh-0008FL-4c for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 09:36:13 +0000 X-Inumbo-ID: c0d80d88-2568-4d52-8d74-6cb5bec0bd7d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c0d80d88-2568-4d52-8d74-6cb5bec0bd7d; Wed, 25 Nov 2020 09:36:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606296971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0AxH2Dn0DtiSCSIRsyowpVLW9AeNSPjSK9xgXtYk0yM=; b=VkxU9j4BcdI4i7O6Fqe8Ztq6cCTzfG+02hKgVIRle5wUJXth61gZZY6gTWaHyqKuFamI87 Vl/DifLxPPWKzx4SwLAwhXwwyP02u9CbwZJ4CayzJSTgCk396p+e8C5+P5SVl5yI6/Z0ay MNovyDIilYG9VYxLXp05hSFUH5k9aZg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F054AC6A; Wed, 25 Nov 2020 09:36:11 +0000 (UTC) Subject: Re: [PATCH v4 1/3] domctl: introduce a new domain create flag, XEN_DOMCTL_CDF_disable_fifo, ... From: Jan Beulich To: Andrew Cooper Cc: Paul Durrant , Eslam Elnikety , Christian Lindig , David Scott , Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Paul Durrant References: <20201124191751.11472-1-paul@xen.org> <20201124191751.11472-2-paul@xen.org> <444917ac-f2aa-5544-8f6c-097e7f57c98c@suse.com> Message-ID: <19792219-22f0-e7ce-23ca-5c1b20d6f581@suse.com> Date: Wed, 25 Nov 2020 10:36:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <444917ac-f2aa-5544-8f6c-097e7f57c98c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.11.2020 10:20, Jan Beulich wrote: > On 24.11.2020 20:17, Paul Durrant wrote: >> --- a/xen/include/public/domctl.h >> +++ b/xen/include/public/domctl.h >> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain { >> #define XEN_DOMCTL_CDF_iommu (1U<<_XEN_DOMCTL_CDF_iommu) >> #define _XEN_DOMCTL_CDF_nested_virt 6 >> #define XEN_DOMCTL_CDF_nested_virt (1U << _XEN_DOMCTL_CDF_nested_virt) >> +#define _XEN_DOMCTL_CDF_disable_fifo 7 >> +#define XEN_DOMCTL_CDF_disable_fifo (1U << _XEN_DOMCTL_CDF_disable_fifo) > > Despite getting longish, I think this needs "evtchn" somewhere in > the name. To keep size bounded, maybe XEN_DOMCTL_CDF_no_fifo_evtchn? > >> /* Max XEN_DOMCTL_CDF_* constant. Used for ABI checking. */ >> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt >> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_disable_fifo > > While not directly related to this patch, I'm puzzled by the > presence of this constant: I've not been able to find any use of > it. In particular you did have a need to modify > sanitise_domain_config(). So it was you to introduce this, right away without any user, in 7fb0e134f8c6 ("tools/ocaml: abi: Use formal conversion and check in more places"). The only reference is from what I regard as a comment (I don't speak any ocaml, so I may be wrong). Could you clarify why we need to maintain this constant? Thanks, Jan