Re: [PATCH] tools/power/turbostat: Fix uncore frequency file string

[Thomas Renninger <trenn@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Freitag, 8. März 2024 21:49:57 CET Justin Ernst wrote:
> Running turbostat on a 16 socket HPE Scale-up Compute 3200 (SapphireRapids)
> fails with: turbostat:
> /sys/devices/system/cpu/intel_uncore_frequency/package_010_die_00/current_f
> req_khz: open failed: No such file or directory
> 
> We observe the sysfs uncore frequency directories named:
> ...
> package_09_die_00/
> package_10_die_00/
> package_11_die_00/
> ...
> package_15_die_00/
> 
> The culprit is an incorrect sprintf format string "package_0%d_die_0%d" used
> with each instance of reading uncore frequency files.
> uncore-frequency-common.c creates the sysfs directory with the format
> "package_%02d_die_%02d". Once the package value reaches double digits, the
> formats diverge.
Yep, currently in:
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
line 238.

Looks like the proper bugfix.
 
> Change each instance of "package_0%d_die_0%d" to "package_%02d_die_%02d".
> 
> Signed-off-by: Justin Ernst <justin.ernst@hpe.com>

Reviewed-by: Thomas Renninger <trenn@suse.de>

       Thomas

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]