All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Julien Grall <julien.grall@arm.com>,
	linux-rt-users@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] v5.2.10-rt5
Date: Tue, 27 Aug 2019 16:26:20 +0200	[thread overview]
Message-ID: <1983406.XYedcDVy8E@ada> (raw)
In-Reply-To: <20190827132200.uj44quypjsqu3oup@linutronix.de>

Hello Sebastian,

Am Dienstag, 27. August 2019, 15:22:01 CEST schrieb Sebastian Andrzej Siewior:
> of course, !SMP. What about this:
> 
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -934,7 +934,11 @@ void hrtimer_grab_expiry_lock(const struct hrtimer
> *timer) {
>  	struct hrtimer_clock_base *base = READ_ONCE(timer->base);
> 
> +#ifdef CONFIG_SMP
>  	if (timer->is_soft && base != &migration_base) {
> +#else
> +	if (timer->is_soft && base && base->cpu_base) {
> +#endif
>  		spin_lock(&base->cpu_base->softirq_expiry_lock);
>  		spin_unlock(&base->cpu_base->softirq_expiry_lock);
>  	}

Build error is gone and target system boots successfully, seems to work fine 
at first sight. Thanks for the quick response.

Greets
Alex


  reply	other threads:[~2019-08-27 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 10:55 [ANNOUNCE] v5.2.10-rt5 Sebastian Andrzej Siewior
2019-08-27 12:34 ` Alexander Dahl
2019-08-27 13:22   ` Sebastian Andrzej Siewior
2019-08-27 14:26     ` Alexander Dahl [this message]
2019-09-10 11:33 ` Gene Heskett
2019-09-10 12:02   ` Alexander Dahl
2019-09-10 19:01     ` Gene Heskett
2019-09-10 12:11   ` Henrik Austad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1983406.XYedcDVy8E@ada \
    --to=ada@thorsis.com \
    --cc=bigeasy@linutronix.de \
    --cc=julien.grall@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.