From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S262504AbUKLKe1@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262504AbUKLKe1 (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 12 Nov 2004 05:34:27 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262499AbUKLKe1
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 12 Nov 2004 05:34:27 -0500
Received: from mx1.redhat.com ([66.187.233.31]:38070 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S262500AbUKLKeM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Nov 2004 05:34:12 -0500
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20041111143148.76dcaba4.akpm@osdl.org> 
References: <20041111143148.76dcaba4.akpm@osdl.org>  <200411081432.iA8EWfmh023432@warthog.cambridge.redhat.com> 
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org,
       uclinux-dev@uclinux.org
Subject: Re: [PATCH] VM routine fixes 
User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Date: Fri, 12 Nov 2004 10:33:55 +0000
Message-ID: <19844.1100255635@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org


> I spy a secret, uncommented, unchangelogged hunk:

Hardly secret. After all, I broadcast it to two mailing lists.

> > +#ifdef CONFIG_MMU
> >  	vma->vm_ops = &generic_file_vm_ops;
> > +#endif
> ...
> What's happening there?

The vm_area_struct doesn't have an ops member when !MMU.

David