Re: [PATCH v4 4/9] bus: add bus helper iterator to find a particular device

[Thomas Monjalon <thomas@monjalon.net>]

21/06/2017 01:29, Gaetan Rivet:
>  /**
> + * Bus iterator to find a particular device.

It should be said that it is iterating over every registered buses.

> + *
> + * If the callback returns non-zero this function will stop iterating over any
> + * more buses and devices. To continue a search the device of a previous search
> + * is passed via the start parameters.
> + *
> + * @param start
> + *	 Start device of the iteration.
> + *
> + * @param cmp
> + *	 Callback function to check device.
> + *
> + * @param data
> + *	 Data to pass to match callback.
> + *
> + * @return
> + *	 A pointer to a rte_bus structure or NULL in case no bus matches.
> + */
> +struct rte_device *
> +rte_bus_find_device(const struct rte_device *start,
> +		    rte_dev_cmp_t cmp, const void *data);

The order of the parameters is different of rte_bus_find():
    struct rte_bus *rte_bus_find(rte_bus_cmp_t cmp,
                                 const void *data,
                                 const struct rte_bus *start);