From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:38382 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbeHTNYV (ORCPT ); Mon, 20 Aug 2018 09:24:21 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, Koji Matsuoka Subject: Re: [PROTO][PATCH 01/10] drm: rcar-du: Add clk_set_rate for external clock device Date: Mon, 20 Aug 2018 13:10:15 +0300 Message-ID: <1985747.4xD5rL3F0m@avalon> In-Reply-To: <1534254604-24204-2-git-send-email-uli+renesas@fpond.eu> References: <1534254604-24204-1-git-send-email-uli+renesas@fpond.eu> <1534254604-24204-2-git-send-email-uli+renesas@fpond.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Tuesday, 14 August 2018 16:49:55 EEST Ulrich Hecht wrote: > From: Koji Matsuoka > > Signed-off-by: Koji Matsuoka > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index b52b3e8..cd6803a 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -229,6 +229,7 @@ static void rcar_du_crtc_set_display_timing(struct > rcar_du_crtc *rcrtc) unsigned long rate; > u32 extdiv; > > + clk_set_rate(rcrtc->extclock, mode_clock); This is a hack, Jacopo has posted "[PATCH 3/3] drm: rcar-du: Improve non-DPLL clock selection" which I think is a better solution (or will be in v2 :-)). > extclk = clk_get_rate(rcrtc->extclock); > if (rcdu->info->dpll_ch & (1 << rcrtc->index)) { > unsigned long target = mode_clock; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PROTO][PATCH 01/10] drm: rcar-du: Add clk_set_rate for external clock device Date: Mon, 20 Aug 2018 13:10:15 +0300 Message-ID: <1985747.4xD5rL3F0m@avalon> References: <1534254604-24204-1-git-send-email-uli+renesas@fpond.eu> <1534254604-24204-2-git-send-email-uli+renesas@fpond.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BD8A88E79 for ; Mon, 20 Aug 2018 10:09:21 +0000 (UTC) In-Reply-To: <1534254604-24204-2-git-send-email-uli+renesas@fpond.eu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, Koji Matsuoka , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVWxyaWNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNCBBdWd1 c3QgMjAxOCAxNjo0OTo1NSBFRVNUIFVscmljaCBIZWNodCB3cm90ZToKPiBGcm9tOiBLb2ppIE1h dHN1b2thIDxrb2ppLm1hdHN1b2thLnhtQHJlbmVzYXMuY29tPgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEtvamkgTWF0c3Vva2EgPGtvamkubWF0c3Vva2EueG1AcmVuZXNhcy5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jIHwgMSArCj4gIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNh ci1kdS9yY2FyX2R1X2NydGMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9j cnRjLmMgaW5kZXggYjUyYjNlOC4uY2Q2ODAzYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfY3J0Yy5jCj4gQEAgLTIyOSw2ICsyMjksNyBAQCBzdGF0aWMgdm9pZCByY2FyX2R1 X2NydGNfc2V0X2Rpc3BsYXlfdGltaW5nKHN0cnVjdAo+IHJjYXJfZHVfY3J0YyAqcmNydGMpIHVu c2lnbmVkIGxvbmcgcmF0ZTsKPiAgCQl1MzIgZXh0ZGl2Owo+IAo+ICsJCWNsa19zZXRfcmF0ZShy Y3J0Yy0+ZXh0Y2xvY2ssIG1vZGVfY2xvY2spOwoKVGhpcyBpcyBhIGhhY2ssIEphY29wbyBoYXMg cG9zdGVkICJbUEFUQ0ggMy8zXSBkcm06IHJjYXItZHU6IEltcHJvdmUgbm9uLURQTEwgCmNsb2Nr IHNlbGVjdGlvbiIgd2hpY2ggSSB0aGluayBpcyBhIGJldHRlciBzb2x1dGlvbiAob3Igd2lsbCBi ZSBpbiB2MiA6LSkpLgoKPiAgCQlleHRjbGsgPSBjbGtfZ2V0X3JhdGUocmNydGMtPmV4dGNsb2Nr KTsKPiAgCQlpZiAocmNkdS0+aW5mby0+ZHBsbF9jaCAmICgxIDw8IHJjcnRjLT5pbmRleCkpIHsK PiAgCQkJdW5zaWduZWQgbG9uZyB0YXJnZXQgPSBtb2RlX2Nsb2NrOwoKLS0gClJlZ2FyZHMsCgpM YXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=