From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH v3] doc: prefer installing using meson rather than ninja
Date: Thu, 22 Jun 2023 20:35:17 +0200 [thread overview]
Message-ID: <1986946.PIDvDuAF1L@thomas> (raw)
In-Reply-To: <20230609145107.144593-1-bruce.richardson@intel.com>
09/06/2023 16:51, Bruce Richardson:
> After doing a build, to install DPDK system-wide our documentation
> recommended using the "ninja install" command. However, for anyone
> building as a non-root user and only installing as root, the "meson
> install" command is a better alternative, as it provides for
> automatically dropping or elevating privileges as necessary in more
> recent meson releases [1].
>
> [1] https://mesonbuild.com/Installing.html#installing-as-the-superuser
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> ---
> V3:
> * correct order of arguments to meson in CI scripts. The "-C" option
> must follow the meson "install" command. [This is consistent with
> other uses e.g. meson compile -C ..., meson test -C ...]
>
> V2:
> * Fix one missed reference to "ninja install" in Linux GSG
> * Changed CI scripts to use "meson install" to ensure step is properly
> tested.
> ---
> .ci/linux-build.sh | 4 ++--
> doc/guides/contributing/coding_style.rst | 2 +-
> doc/guides/cryptodevs/uadk.rst | 2 +-
> doc/guides/freebsd_gsg/build_dpdk.rst | 2 +-
> doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +-
> doc/guides/linux_gsg/build_dpdk.rst | 4 ++--
> doc/guides/prog_guide/build-sdk-meson.rst | 4 ++--
> 7 files changed, 10 insertions(+), 10 deletions(-)
I see other occurences which could be replaced:
.ci/linux-build.sh: [ -d install ] || DESTDIR=$(pwd)/install ninja -C build install
devtools/test-meson-builds.sh: echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose
devtools/test-meson-builds.sh: DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose
doc/guides/nics/mlx4.rst: ninja install
doc/guides/platform/mlx5.rst: ninja install
next prev parent reply other threads:[~2023-06-22 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 10:51 [PATCH] doc: prefer installing using meson rather than ninja Bruce Richardson
2023-06-09 11:13 ` David Marchand
2023-06-09 11:19 ` Bruce Richardson
2023-06-09 11:21 ` David Marchand
2023-06-09 13:34 ` [PATCH v2] " Bruce Richardson
2023-06-09 14:51 ` [PATCH v3] " Bruce Richardson
2023-06-22 18:35 ` Thomas Monjalon [this message]
2023-06-23 7:54 ` Bruce Richardson
2023-06-23 11:43 ` [PATCH v4] " Bruce Richardson
2023-06-28 0:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1986946.PIDvDuAF1L@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.