From: David Howells <dhowells@redhat.com>
To: David Jeffery <djeffery@redhat.com>
Cc: dhowells@redhat.com, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring
Date: Thu, 12 Feb 2015 16:46:14 +0000 [thread overview]
Message-ID: <19888.1423759574@warthog.procyon.org.uk> (raw)
In-Reply-To: <20150211212647.GA425@rage.redhat.com>
David Jeffery <djeffery@redhat.com> wrote:
> If a request_key() call to allocate and fill out a key attempts to insert the
> key structure into a revoked keyring, the key will leak, using memory and part
> of the user's key quota until the system reboots. This is from a failure of
> construct_alloc_key() to decrement the key's reference count after the attempt
> to insert into the requested keyring is rejected.
>
> key_put() needs to be called in the link_prealloc_failed callpath to ensure
> the unused key is released.
Applied.
next prev parent reply other threads:[~2015-02-12 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 21:26 [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring David Jeffery
2015-02-12 16:46 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-12 16:45 David Howells
2015-02-16 2:27 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19888.1423759574@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=djeffery@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.