From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
Narcisa.Vasile@microsoft.com, tbashar@mellanox.com,
Harini.Ramakrishnan@microsoft.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] build: treat warning as an error on Windows
Date: Thu, 11 Jun 2020 18:12:15 +0200 [thread overview]
Message-ID: <198987692.ZIs5KhJ6DU@thomas> (raw)
In-Reply-To: <20200528231455.13636-3-pallavi.kadam@intel.com>
29/05/2020 01:14, Pallavi Kadam:
> Added -Werror in meson file to consider all the warnings
> as errors on Windows.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
> --- a/config/meson.build
> +++ b/config/meson.build
> +# add -Werror to treat warnings as errors on Windows
> +if is_windows
> + warning_flags += '-Werror'
> +endif
This should be not needed.
When configuring meson in a CI, we are supposed to use
--werror as it is done in devtools/test-meson-builds.sh.
next prev parent reply other threads:[~2020-06-11 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 22:53 [dpdk-dev] [PATCH] eal: fix warnings on Windows Pallavi Kadam
2020-05-14 0:43 ` Dmitry Kozlyuk
2020-05-14 1:24 ` Ranjit Menon
2020-05-14 8:02 ` Thomas Monjalon
2020-05-14 17:46 ` Ranjit Menon
2020-05-14 20:39 ` [dpdk-dev] [PATCH v2] " Pallavi Kadam
2020-05-15 19:20 ` Dmitry Kozlyuk
2020-05-18 22:08 ` Narcisa Ana Maria Vasile
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 0/2] Fix Windows compiler warnings Pallavi Kadam
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows Pallavi Kadam
2020-06-11 16:14 ` Thomas Monjalon
2020-06-11 18:55 ` Kadam, Pallavi
2020-05-28 23:14 ` [dpdk-dev] [PATCH v3 2/2] build: treat warning as an error " Pallavi Kadam
2020-06-11 16:12 ` Thomas Monjalon [this message]
2020-06-11 18:54 ` Kadam, Pallavi
2020-06-11 19:50 ` [dpdk-dev] [PATCH v4] eal: fix warnings " Pallavi Kadam
2020-06-11 20:18 ` Narcisa Ana Maria Vasile
2020-06-15 9:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198987692.ZIs5KhJ6DU@thomas \
--to=thomas@monjalon.net \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=tbashar@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.