Re: [PATCH 11/22] pinctrl: qcom: sa8775p: Add support for SA8255p SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/09/2024 17:24, Nikunj Kela wrote:
> 
> On 8/30/2024 2:52 AM, Krzysztof Kozlowski wrote:
>> On 29/08/2024 16:17, Nikunj Kela wrote:
>>> On 8/29/2024 12:29 AM, Krzysztof Kozlowski wrote:
>>>> On Wed, Aug 28, 2024 at 01:37:10PM -0700, Nikunj Kela wrote:
>>>>> SA8255p platform uses the same TLMM block as used in SA8775p,
>>>>> though the pins are split between Firmware VM and Linux VM.
>>>>> let's add SA8255p specific compatible.
>>>> The change suggests devices are fully compatible, but above description
>>>> does not.
>>>>
>>>> This looks conflicting.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>> Hi Krzysztof,
>>>
>>> Thanks for reviewing patches. TLMM HW block is exactly same as used in
>>> SA8775p however ownership of pins can be split between firmware VM and
>>> Linux VM. It is upto devices to decide what pins they want to use in
>>> what VM. I will extend the subject with same description as used in DT
>>> binding.
>> So there is no difference? Then devices should be made compatible with
>> fallback.
>>
>> Best regards,
>> Krzysztof
> 
> Yes, I get your point now. I will discuss internally. I am leaning
> towards using sa8775p-tlmm compatible in SA8255p TLMM node so there is
> no need for adding new compatible. Will drop the two pincontrol related
> patches from the series in next version if agreed internally.
> 

You need compatible followed by fallback (and therefore drop driver
change). That's how compatibility is expressed.


Best regards,
Krzysztof