[PATCH] libnfnetlink-1.0.0 iftable.c:nlif_open() has handler unregister error

[Kuzin Andrey <kuzinandrey@yandex.ru>]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

struct nlif_handle *nlif_open(void)
{
..........
    if (rtnl_handler_register(h->rtnl_handle, &h->ifadd_handler) < 0)
         goto err_close;
    if (rtnl_handler_register(h->rtnl_handle, &h->ifdel_handler) < 0)
         goto err_unregister;
    return h;
err_unregister:
    rtnl_handler_unregister(h->rtnl_handle, &h->ifdel_handler);
err_close:
    rtnl_close(h->rtnl_handle);
    free(h);
err:
    return NULL;
}


Here if was error after rtnl_handler_register(... ifdel_handler...) need to unregister the ifadd_handler,
but in err_unregister: try to unregister the the ifdel_handler.





[-- Attachment #2: 2.patch --]
[-- Type: application/octet-stream, Size: 372 bytes --]

--- ./a/iftable.c	2009-01-07 04:32:26.000000000 +0300
+++ ./b/iftable.c	2010-09-30 10:35:30.000000000 +0400
@@ -245,7 +245,7 @@ struct nlif_handle *nlif_open(void)
 	return h;
 
 err_unregister:
-	rtnl_handler_unregister(h->rtnl_handle, &h->ifdel_handler);
+	rtnl_handler_unregister(h->rtnl_handle, &h->ifadd_handler);
 err_close:
 	rtnl_close(h->rtnl_handle);
 	free(h);