From: "Arnd Bergmann" <arnd@arndb.de>
To: "laurent.pinchart" <laurent.pinchart@ideasonboard.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] media: i2c: mt9m114: add CONFIG_COMMON_CLK dependency
Date: Wed, 13 Dec 2023 12:23:05 +0100 [thread overview]
Message-ID: <1992d665-cb98-4190-bee3-e5629c7d0e8d@app.fastmail.com> (raw)
In-Reply-To: <20231213095849.GA2191@pendragon.ideasonboard.com>
On Wed, Dec 13, 2023, at 10:58, Laurent Pinchart wrote:
> On Wed, Dec 13, 2023 at 09:10:19AM +0000, Sakari Ailus wrote:
>> On Wed, Dec 13, 2023 at 09:39:01AM +0100, Arnd Bergmann wrote:
>> > On Wed, Dec 13, 2023, at 09:09, Sakari Ailus wrote:
>>
>> The datasheet says the input clock range is between 6 MHz and 54 MHz. We
>> could check that, and return an error if it's not in the range. The rate is
>> needed for other reasons, too, and the sensor is unlikely to work if it's
>> (more than little) off.
>>
>> I wonder if this could address the Clang 16 issue, too? I'd replace
>> udelay() with fsleep() in any case, and at the very least Clang should be
>> happy with this.
>
> I'm fine with both of those changes.
I verified that the build failure is solved by either one.
I would just do the fsleep() change in that case since that
is a sensible change regardless of the undefined behavior.
I'll send a v2.
Arnd
prev parent reply other threads:[~2023-12-13 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 21:18 [PATCH] media: i2c: mt9m114: add CONFIG_COMMON_CLK dependency Arnd Bergmann
2023-12-13 8:09 ` Sakari Ailus
2023-12-13 8:32 ` Sakari Ailus
2023-12-13 8:39 ` Arnd Bergmann
2023-12-13 9:10 ` Sakari Ailus
2023-12-13 9:58 ` Laurent Pinchart
2023-12-13 11:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1992d665-cb98-4190-bee3-e5629c7d0e8d@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=justinstitt@google.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.