From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2] eal: fix duplicate function declaration
Date: Sun, 18 Nov 2018 13:41:38 +0100 [thread overview]
Message-ID: <1994389.ETnpRDjGGD@xps> (raw)
In-Reply-To: <fc850c96-c9ca-8678-d15c-15c81795e8d6@intel.com>
14/11/2018 12:24, Burakov, Anatoly:
> On 14-Nov-18 11:20 AM, Kevin Laatz wrote:
> > The rte_eal_get_runtime_dir() function is currently being declared in two
> > header files.
> >
> > This API was made public in commit 6911c9fd8fbe ("eal: export function to
> > get runtime directory"), adding it to rte_eal.h. To make it public, the
> > 'rte' prefix was added to the function so it needed to be modified in the
> > original location of the declaration, eal_filesystem.h. By only modifying,
> > and not removing the decalration, it is now a duplicate.
> >
> > This patch removes the declaration from eal_filesystem.h.
> >
> > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
> >
> > Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> >
> > ---
> > v2:
> > - Fix commit message (checkpatch warning)
> > ---
>
> I was too late to ack the first one...
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-11-18 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 11:20 [PATCH v2] eal: fix duplicate function declaration Kevin Laatz
2018-11-14 11:24 ` Burakov, Anatoly
2018-11-18 12:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1994389.ETnpRDjGGD@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.