All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
To: xen-devel@lists.xen.org
Cc: boris.ostrovsky@oracle.com, Brendan Gregg <bgregg@netflix.com>
Subject: Re: [PATCH v2 1/2] x86/VPMU: return correct fixed PMC count
Date: Wed, 25 Nov 2015 10:13:09 +0100	[thread overview]
Message-ID: <1994616.xHA5sAh0S4@amur> (raw)
In-Reply-To: <1448409192-4914-2-git-send-email-bgregg@netflix.com>

Am Dienstag 24 November 2015, 15:53:11 schrieb Brendan Gregg:
> Fixes a register typo.
> 
> Signed-off-by: Brendan Gregg <bgregg@netflix.com>
> ---
>  xen/arch/x86/cpu/vpmu_intel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>

> 
> diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c
> index 12f80ae..8d83a1a 100644
> --- a/xen/arch/x86/cpu/vpmu_intel.c
> +++ b/xen/arch/x86/cpu/vpmu_intel.c
> @@ -166,10 +166,10 @@ static int core2_get_arch_pmc_count(void)
>   */
>  static int core2_get_fixed_pmc_count(void)
>  {
> -    u32 eax;
> +    u32 edx;
>  
> -    eax = cpuid_eax(0xa);
> -    return MASK_EXTR(eax, PMU_FIXED_NR_MASK);
> +    edx = cpuid_edx(0xa);
> +    return MASK_EXTR(edx, PMU_FIXED_NR_MASK);
>  }
>  
>  /* edx bits 5-12: Bit width of fixed-function performance counters  */
> 

-- 
Company details: http://ts.fujitsu.com/imprint.html

  reply	other threads:[~2015-11-25  9:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 23:53 [PATCH v2 0/2] Restricted VPMU filter flags Brendan Gregg
2015-11-24 23:53 ` [PATCH v2 1/2] x86/VPMU: return correct fixed PMC count Brendan Gregg
2015-11-25  9:13   ` Dietmar Hahn [this message]
2015-11-25  9:55   ` Jan Beulich
2015-11-25 14:26     ` Boris Ostrovsky
2015-11-25 15:31       ` Jan Beulich
2015-11-25 19:32         ` Boris Ostrovsky
2015-11-26  7:44           ` Jan Beulich
2015-11-24 23:53 ` [PATCH v2 2/2] x86/VPMU: implement ipc and arch filter flags Brendan Gregg
2015-11-25 15:13   ` Boris Ostrovsky
2015-11-25 23:35     ` Brendan Gregg
2015-11-26  8:11   ` Dietmar Hahn
2015-12-01  0:32     ` Brendan Gregg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1994616.xHA5sAh0S4@amur \
    --to=dietmar.hahn@ts.fujitsu.com \
    --cc=bgregg@netflix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.