From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: linux@cthulhu.engr.sgi.com
Subject: SCSI problem solved
Date: Sun, 13 Sep 1998 00:38:02 +0200 [thread overview]
Message-ID: <19980913003802.06252@alpha.franken.de> (raw)
Right now I'm doing some stress test with my Indy (dd from DAT and untaring
a tar file from one disk to another at the same time). And it hasn't crashed.
Below is the patch I'm using. If it works for others too, I'll check it in.
Thomas.
Index: sgiwd93.c
===================================================================
RCS file: /var/mips/linus/cvs/linux/drivers/scsi/sgiwd93.c,v
retrieving revision 1.8
diff -u -r1.8 sgiwd93.c
--- sgiwd93.c 1998/08/25 09:18:49 1.8
+++ sgiwd93.c 1998/09/12 22:32:01
@@ -77,7 +77,7 @@
static int dma_setup(Scsi_Cmnd *cmd, int datainp)
{
- struct WD33C93_hostdata *hdata = CMDHOSTDATA(cmd);
+ struct WD33C93_hostdata *hdata = (struct WD33C93_hostdata *)cmd->host->hostdata;
wd33c93_regs *regp = hdata->regp;
struct hpc3_scsiregs *hregs = (struct hpc3_scsiregs *) cmd->host->base;
struct hpc_chunk *hcp = (struct hpc_chunk *) hdata->dma_bounce_buffer;
@@ -89,14 +89,14 @@
hdata->dma_dir = datainp;
- if(cmd->use_sg) {
+ if(cmd->SCp.buffers_residual) {
struct scatterlist *slp = cmd->SCp.buffer;
int i, totlen = 0;
#ifdef DEBUG_DMA
printk("SCLIST<");
#endif
- for(i = 0; i <= (cmd->use_sg - 1); i++, hcp++) {
+ for(i = 0; i <= cmd->SCp.buffers_residual; i++, hcp++) {
#ifdef DEBUG_DMA
printk("[%p,%d]", slp[i].address, slp[i].length);
#endif
@@ -146,7 +146,7 @@
static void dma_stop(struct Scsi_Host *instance, Scsi_Cmnd *SCpnt,
int status)
{
- struct WD33C93_hostdata *hdata = INSTHOSTDATA(instance);
+ struct WD33C93_hostdata *hdata = (struct WD33C93_hostdata *)instance->hostdata;
wd33c93_regs *regp = hdata->regp;
struct hpc3_scsiregs *hregs = (struct hpc3_scsiregs *) SCpnt->host->base;
@@ -163,7 +163,7 @@
hregs->ctrl = 0;
/* See how far we got and update scatterlist state if necessary. */
- if(SCpnt->use_sg) {
+ if(SCpnt->SCp.buffers_residual) {
struct scatterlist *slp = SCpnt->SCp.buffer;
int totlen, wd93_residual, transferred, i;
@@ -183,7 +183,7 @@
#ifdef DEBUG_DMA
printk("Jed was here...");
#endif
- for(i = 0; i <= (SCpnt->use_sg - 1); i++) {
+ for(i = 0; i <= SCpnt->SCp.buffers_residual; i++) {
if(slp[i].length >= transferred)
break;
transferred -= slp[i].length;
@@ -193,10 +193,10 @@
#ifdef DEBUG_DMA
printk("did it all...");
#endif
- i = (SCpnt->use_sg - 1);
+ i = SCpnt->SCp.buffers_residual;
}
SCpnt->SCp.buffer = &slp[i];
- SCpnt->SCp.buffers_residual = (SCpnt->use_sg - 1 - i);
+ SCpnt->SCp.buffers_residual = SCpnt->SCp.buffers_residual - i;
SCpnt->SCp.ptr = (char *) slp[i].address;
SCpnt->SCp.this_residual = slp[i].length;
}
@@ -244,7 +244,7 @@
wd33c93_init(sgiwd93_host, (wd33c93_regs *) 0xbfbc0003,
dma_setup, dma_stop, WD33C93_FS_16_20);
- hdata = INSTHOSTDATA(sgiwd93_host);
+ hdata = (struct WD33C93_hostdata *)sgiwd93_host->hostdata;
hdata->no_sync = 0;
hdata->dma_bounce_buffer = (uchar *) (KSEG1ADDR(buf));
dma_cache_wback_inv((unsigned long) buf, PAGE_SIZE);
--
See, you not only have to be a good coder to create a system like Linux,
you have to be a sneaky bastard too ;-)
[Linus Torvalds in <4rikft$7g5@linux.cs.Helsinki.FI>]
next reply other threads:[~1998-09-12 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-09-12 22:38 Thomas Bogendoerfer [this message]
1998-09-14 23:42 ` SCSI problem solved ralf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19980913003802.06252@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux@cthulhu.engr.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.