From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 2/2] gfs2: preserve i_mode if __gfs2_set_acl() fails
Date: Thu, 31 Aug 2017 09:12:07 -0400 (EDT) [thread overview]
Message-ID: <1998936240.4008871.1504185127694.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170831063333.GA7274@debian.home>
----- Original Message -----
| When changing a file's acl mask, __gfs2_set_acl() will first set the
| group bits of i_mode to the value of the mask, and only then set the
| actual extended attribute representing the new acl.
|
| If the second part fails (due to lack of space, for example) and the
| file had no acl attribute to begin with, the system will from now on
| assume that the mask permission bits are actual group permission bits,
| potentially granting access to the wrong users.
|
| Prevent this by only changing the inode mode after the acl has been set.
|
| Signed-off-by: Ernesto A. Fern?ndez <ernesto.mnd.fernandez@gmail.com>
| ---
Hi,
Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=309e8cda596f6552a32dd14b969ce9b17f837f2f
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2017-08-31 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 6:29 [Cluster-devel] [PATCH 1/2] gfs2: don't return ENODATA in __gfs2_xattr_set unless replacing Ernesto A. Fernández
2017-08-27 6:30 ` [Cluster-devel] [PATCH 2/2] gfs2: preserve i_mode if __gfs2_set_acl() fails Ernesto A. Fernández
2017-08-30 12:43 ` Bob Peterson
2017-08-31 6:33 ` [Cluster-devel] [PATCH v2 " Ernesto A. Fernández
2017-08-31 13:12 ` Bob Peterson [this message]
2017-08-31 13:11 ` [Cluster-devel] [PATCH 1/2] gfs2: don't return ENODATA in __gfs2_xattr_set unless replacing Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1998936240.4008871.1504185127694.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.