All of lore.kernel.org
 help / color / mirror / Atom feed
From: ralf@uni-koblenz.de
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux@cthulhu.engr.sgi.com, linux-mips@fnet.fr,
	linux-mips@vger.rutgers.edu
Subject: Re: Unused memory
Date: Mon, 11 Jan 1999 00:48:48 +0100	[thread overview]
Message-ID: <19990111004848.C18917@uni-koblenz.de> (raw)
In-Reply-To: <19990110172259.A2057@alpha.franken.de>; from Thomas Bogendoerfer on Sun, Jan 10, 1999 at 05:22:59PM +0100

On Sun, Jan 10, 1999 at 05:22:59PM +0100, Thomas Bogendoerfer wrote:

> I now know the reason for this. Before giving out memory via brk() the
> kernel checks, whether there is enough memory. The kernel holds back
> (2 + page_cache.min_percent + buffer_mem.min_pecent) percent of the
> available memory (see function vm_enough_memory() in mm/mmap.c). Problem
> on the Indy is, that num_physpages is wrong by 128MB, because we account
> the memory by only looking at the highest page number and forget about 
> holes in the memory map. And the Indy has a big hole between 0x80002000 
> and 0x88002000 ...
> 
> Right now I can't think of a good fix for this problem. Any ideas ?

Attached is a quickfix which just fixes the calculation of num_physpages.
The real thing is to us the PG_skip flag and implement the PageSkip macro.
See the Sparc / Sparc64 code for how to implement.  Implementing this
will save us alot of memory as well.  I'll post a real patch later.

  Ralf

--- arch/mips/mm/init.c.orig	Sun Jan 10 23:50:12 1999
+++ arch/mips/mm/init.c	Sun Jan 10 23:50:53 1999
@@ -247,8 +247,9 @@
 #endif
 
 	end_mem &= PAGE_MASK;
-	max_mapnr = num_physpages = MAP_NR(end_mem);
+	max_mapnr = MAP_NR(end_mem);
 	high_memory = (void *)end_mem;
+	num_physpages = 0;
 
 	/* mark usable pages in the mem_map[] */
 	start_mem = PAGE_ALIGN(start_mem);
@@ -278,6 +279,7 @@
 				datapages++;
 			continue;
 		}
+		num_physpages++;
 		atomic_set(&mem_map[MAP_NR(tmp)].count, 1);
 #ifdef CONFIG_BLK_DEV_INITRD
 		if (!initrd_start || (tmp < initrd_start || tmp >=

      reply	other threads:[~1999-01-11  0:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-01-10 16:22 Unused memory Thomas Bogendoerfer
1999-01-10 23:48 ` ralf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19990111004848.C18917@uni-koblenz.de \
    --to=ralf@uni-koblenz.de \
    --cc=linux-mips@fnet.fr \
    --cc=linux-mips@vger.rutgers.edu \
    --cc=linux@cthulhu.engr.sgi.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.