All of lore.kernel.org
 help / color / mirror / Atom feed
From: kanoj@google.engr.sgi.com (Kanoj Sarcar)
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux-MM@kvack.org
Subject: Re: [PATCH] kanoj-mm2.0-2.2.9 unneccesary page force in by munlock
Date: Mon, 17 May 1999 10:31:57 -0700 (PDT)	[thread overview]
Message-ID: <199905171731.KAA20435@google.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.3.95.990517091025.10344C-100000@penguin.transmeta.com> from "Linus Torvalds" at May 17, 99 09:11:19 am

> 
> 
> On Sun, 16 May 1999, Kanoj Sarcar wrote:
> > 
> > Hmm, my logic was a little bit different. Note that you can call munlock()
> > on a range even when a previous mlock() has not been done on the range (I
> > think that's not an munlock error in POSIX). In 2.2.9, this would end up
> > faulting in the pages, which doesn't need to happen ... (haven't really
> > thought whether "root" can erroneously force memory deadlocks this way)
> 
> Well, if you look closely, the mlock_fixup() routine tests whether
> lockedness has changed and returns early if it hasn't.. So in your case
> nothing at all would have been done..
> 
> 		Linus

Indeed, it does, my mistake ... it still makes sense to clean up the
code, as you mentioned originally ...

Thanks.

Kanoj
kanoj@engr.sgi.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/

      reply	other threads:[~1999-05-17 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-05-17  4:02 [PATCH] kanoj-mm2.0-2.2.9 unneccesary page force in by munlock Kanoj Sarcar
1999-05-17  4:48 ` Linus Torvalds
1999-05-17  6:16   ` Kanoj Sarcar
1999-05-17 16:11     ` Linus Torvalds
1999-05-17 17:31       ` Kanoj Sarcar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199905171731.KAA20435@google.engr.sgi.com \
    --to=kanoj@google.engr.sgi.com \
    --cc=Linux-MM@kvack.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.