All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Corry <erik@arbat.com>
To: "Benjamin C.R. LaHaise" <blah@kvack.org>
Cc: Kanoj Sarcar <kanoj@google.engr.sgi.com>,
	ak-uu@muc.de, linux-mm@kvack.org
Subject: Re: Assumed Failure rates in Various o.s's ?
Date: Fri, 21 May 1999 16:54:32 +0200	[thread overview]
Message-ID: <19990521165432.A13600@arbat.com> (raw)
In-Reply-To: <Pine.LNX.3.95.990521101041.17710A-100000@as200.spellcast.com>; from Benjamin C.R. LaHaise on Fri, May 21, 1999 at 10:25:42AM -0400

On Fri, May 21, 1999 at 10:25:42AM -0400, Benjamin C.R. LaHaise wrote:
> On Fri, 21 May 1999, Erik Corry wrote:
> 
> > According to Andi you already fixed this with a read lock that
> > prevents mmap and mmunmap from doing anything while the copy
> > is running.  This makes sense, since if you do it right with a
> > readers/writers lock you can keep out mmap without serialising
> > copy_to_user or copy_from_user.
> 
> I really like the cleanliness of this approach, but it's troublesome:
> memory allocations in other threads would then get blocked during large
> IOs -- very bad.

Actually, isn't it just munmap that is problematic?

After the access_ok you can't map a read-only file into the
path of an oncoming copy_to_user without first unmapping
what was there before (this is assuming a version of
access_ok that checks whether something was mapped).
So mmaps can safely happen in parallel with copy_to_user.

-- 
Erik Corry erik@arbat.com           Ceterum censeo, Microsoftem esse delendam!
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/

  reply	other threads:[~1999-05-21 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <199905191428.QAA1295681@beryllium.daimi.au.dk>
1999-05-19 17:37 ` Assumed Failure rates in Various o.s's ? Kanoj Sarcar
1999-05-21 10:07   ` Erik Corry
1999-05-21 14:25     ` Benjamin C.R. LaHaise
1999-05-21 14:54       ` Erik Corry [this message]
1999-05-21 16:02         ` Benjamin C.R. LaHaise
1999-05-21 17:06       ` Kanoj Sarcar
1999-05-21 17:23     ` Kanoj Sarcar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19990521165432.A13600@arbat.com \
    --to=erik@arbat.com \
    --cc=ak-uu@muc.de \
    --cc=blah@kvack.org \
    --cc=kanoj@google.engr.sgi.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.