From: Philipp Rumpf <prumpf@suse.de>
To: parisc-linux@thepuffingroup.com
Subject: [parisc-linux] Code Readability
Date: Sat, 23 Oct 1999 02:33:18 +0200 [thread overview]
Message-ID: <19991023023318.D22908@suse.de> (raw)
As there already seems to be a discussion going on about this, here's a list
of things I would change in order to save developers time; this is obviously
biased towards developers who spent some time doing this, not towards those
new to the code.
- get rid of the cvs $Log$s. Not only do they tend to get longer than the
code in question, they also seem to be downright boring to me. The only
information you need in the common case is "who was the last one to modify
this file" which $Id$ does just fine.
- use #if 0 (or #ifdef SOMETHING) instead of "/*" to comment out sections of
code more than one line long.
- try to avoid using C++-style "//" line comments, or any comment style except
the usual one, which is
line; /* line comment */
/*
* long comment
* ...
*/
- if you use #ifdef SOMETHING_DEBUG to conditionally compile sanity checks,
put an #undef SOMETHING_DEBUG or #define SOMETHING_DEBUG at the top of the
file. If it is a header file, you don't want to run into problems because
#define SOMETHING_DEBUG is in some .c files and not in others.
- stay with standard linux names. We're pretty good at that.
- look at Documentation/CodingStyle once in a while, especially Chapter 4
Philipp Rumpf
reply other threads:[~1999-10-23 0:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19991023023318.D22908@suse.de \
--to=prumpf@suse.de \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.