All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Nielsen <ran@krazynet.com>
To: linuxppc-dev@lists.linuxppc.org
Subject: Re: esound for PPC
Date: Mon, 25 Oct 1999 22:29:05 -0700	[thread overview]
Message-ID: <19991025222905.A32256@gondolin.asf> (raw)
In-Reply-To: <19991024223141.A758@HSE-MTL-ppp4328.qc.sympatico.ca>; from dorland@lords.com on Sun, Oct 24, 1999 at 10:31:41 -0400


Eric Dorland wrote:
> On Sat, Oct 23, 1999 at 08:33:34PM -0700, Ryan Nielsen wrote:
> > Eric Dorland wrote:
> > > I finally had the chance to recompile my kernel and try your patch, which so
> > > far is working flawlessly. The only bug i've noticed is that regular beeps
> > > sound slightly clipped. You should post the patch to the list if you haven't
> > > already done so :)
> > 
> > does it fix the esound problem ?
> 
> It does indeed.
>  
> > I posted it to the list before but noone replied except for one saying it broke
> > a workaround for a bug, search the dev list at lists.linuxppc.org for 'dmasound bug'.
> 
> Yes, there is a bit of a hissing, but I find the hissing is only noticable
> at really high volumes, on my G3, so it doesn't bother me at all.

can someone fix that hissing problem and get this patch into the kernel ?
diff -u -r1.41.2.2 dmasound.c
--- dmasound.c	1999/08/16 01:58:47	1.41.2.2
+++ dmasound.c	1999/10/25 22:15:23
@@ -3169,9 +3169,9 @@
 	if (beep_playing) {
 		/* sound takes precedence over beeps */
 		out_le32(&awacs_txdma->control, (RUN|PAUSE|FLUSH|WAKE) << 16);
-		out_le32(&awacs->control,
-			 (in_le32(&awacs->control) & ~0x1f00)
-			 || (awacs_rate_index << 8));
+		out_le32(&awacs->control, MASK_IEPC
+			 | (awacs_rate_index << 8) | 0x11
+			 | (awacs_revision < AWACS_BURGUNDY? MASK_IEE: 0));
 		out_le32(&awacs->byteswap, sound.hard.format != AFMT_S16_BE);
 		beep_playing = 0;
 	}
@@ -3259,6 +3259,11 @@
 	save_flags(flags); cli();
 	if (beep_playing) {
 		st_le16(&beep_dbdma_cmd->command, DBDMA_STOP);
+		out_le32(&awacs_txdma->control, (RUN|PAUSE|FLUSH|WAKE) << 16);
+		out_le32(&awacs->control, MASK_IEPC
+			 | (awacs_rate_index << 8) | 0x11
+			 | (awacs_revision < AWACS_BURGUNDY? MASK_IEE: 0));
+		out_le32(&awacs->byteswap, sound.hard.format != AFMT_S16_BE);
 		beep_playing = 0;
 	}
 	restore_flags(flags);

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  parent reply	other threads:[~1999-10-26  5:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-10-03  3:48 esound for PPC Eric Dorland
1999-10-03  4:03 ` Elliot Lee
1999-10-03 18:54   ` Eric Dorland
1999-10-03 19:23     ` Tom Rini
1999-10-03 21:46       ` Elliot Lee
1999-10-04  6:27         ` Geert Uytterhoeven
1999-10-04 15:58           ` Elliot Lee
1999-10-05  8:54             ` Benjamin Herrenschmidt
1999-10-05 11:36               ` Elliot Lee
1999-10-06  0:40                 ` Eric Dorland
1999-10-11  6:06                   ` Eric Dorland
1999-10-11 19:43                     ` Eric Dorland
1999-10-11 20:09                       ` Tom Rini
1999-10-12  3:03                         ` Ryan Nielsen
1999-10-12  3:10                           ` Tom Rini
     [not found]                           ` <19991014193940.A1143@HSE-MTL-ppp4505.qc.sympatico.ca>
     [not found]                             ` <19991017190502.A13068@gondolin.asf>
     [not found]                               ` <19991023152110.A525@HSE-MTL-ppp4445.qc.sympatico.ca>
     [not found]                                 ` <19991023203334.A26715@gondolin.asf>
     [not found]                                   ` <19991024223141.A758@HSE-MTL-ppp4328.qc.sympatico.ca>
1999-10-26  5:29                                     ` Ryan Nielsen [this message]
1999-10-26  6:30                                       ` recv programming problem Morningstar
1999-10-26 14:10                                       ` esound for PPC Dan Malek
1999-10-12  3:10                         ` Eric Dorland
1999-10-12  3:20                           ` Tom Rini
1999-10-12  4:26                             ` Eric Dorland
1999-11-02 18:01                           ` Elliot Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19991025222905.A32256@gondolin.asf \
    --to=ran@krazynet.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.