All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Clément Léger" <cleger@meta.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg
Date: Mon, 16 Nov 2026 19:45:56 -0700	[thread overview]
Message-ID: <19c6db06-d63a-4dc8-9b0d-11fba039b714@kernel.dk> (raw)
In-Reply-To: <20261116111744.702159-3-cleger@meta.com>

On 11/16/26 4:17 AM, Clément Léger wrote:
> IORING_RECVSEND_BUNDLE was disabled for IORING_OP_RECVMSG because the
> envelope and control-message sizing was not implemented. Enable
> bundled multishot recvmsg by reserving its metadata in the first buffer
> and accounting for payload spread across the selected buffer run.

Patch 1 is fine (though both need rebasing against for-7.5/io_uring),
but a few notes on this one:

1) This changes behavior for UDP, which has no inq as per a comment
   in here as well, now it asks for MAX_RW_LEN.
2) Why not support incremental buffer rings?

And the usual, do you have a liburing test and man page updates as
well?

A minor note is that the commenting is a bit excessive... I'd prune
that for v2.

-- 
Jens Axboe


  reply	other threads:[~2026-11-17  2:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 11:17 [PATCH 0/2] io_uring/net: Add bundle support for multishot recvmsg Clément Léger
2026-11-16 11:17 ` [PATCH 1/2] io_uring/net: Factor out receive buffer selection Clément Léger
2026-11-16 11:17 ` [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg Clément Léger
2026-11-17  2:45   ` Jens Axboe [this message]
2026-11-17 12:06     ` Clément Léger
2026-11-17 12:26       ` Jens Axboe
2026-11-17 13:20         ` Clément Léger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19c6db06-d63a-4dc8-9b0d-11fba039b714@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=cleger@meta.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.