Re: [PATCH] erofs-utils: lib: add support for symlink file in erofs_ilookup()

[Hongzhen Luo <hongzhen@linux.alibaba.com>]

On 2024/8/12 11:03, Gao Xiang wrote:
>
>
> On 2024/8/12 10:50, Hongzhen Luo wrote:
>>
>> On 2024/8/12 10:24, Gao Xiang wrote:
>>>
>>>
>>> On 2024/8/11 16:09, Hongzhen Luo wrote:
>>>> When the `path` contains symbolic links, erofs_ilookup() does not
>>>> function properly. This adds support for symlink files.
>>>
>>> Can you explain what's the use cases of this patch?
>>>
>>> It seems both erofsfuse and fsck.erofs --extract don't need this.
>>>
>> Some third-party applications (such as Alibaba DADI) require 
>> obtaining block mapping information of files based on their paths 
>> using liberofs. When file paths include symbolic links, the current 
>> erofs_ilookup() function fails to correctly locate the inode. This 
>> submission enhances erofs_ilookup()'s support for symbolic link files.
>
> Why it cannot be implemented in the application itself?
> Following block mapping and obtain the symlinked file block
> mapping is weird for erofs itself to resolve.
>
> Thanks,
> Gao Xiang

That makes sense. Thanks for pointing it out, and please disregard this 
patch.

---

Thanks,

Hongzhen Luo