Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/02/2025 12:45, Paul Menzel wrote:
> Dear Neeraj,
> 
> 
> Thank you for your patch.
> 
> 
> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
>> Allow user to set custom BD address for NXP chipsets.
>>
>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
>> v3: Drop local-bd-address: true (Krzysztof)
>> ---
>>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> index 0a2d7baf5db3..a84c1c21b024 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> @@ -17,6 +17,9 @@ description:
>>   maintainers:
>>     - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>>   
>> +allOf:
>> +  - $ref: bluetooth-controller.yaml#
>> +
>>   properties:
>>     compatible:
>>       enum:
>> @@ -43,7 +46,7 @@ properties:
>>   required:
>>     - compatible
>>   
>> -additionalProperties: false
>> +unevaluatedProperties: false
> 
> How is this diff related to the change mentioned in the commit message?

It is exactly related, because otherwise custom BD address would not be
allowed.

Read previous discussions and example schema before questioning, because
otherwise this is nitpicking.

Best regards,
Krzysztof