From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F33A1C433EF for ; Wed, 23 Mar 2022 18:33:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ACC9983F89; Wed, 23 Mar 2022 19:33:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kihAt9QP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3406A81D4B; Wed, 23 Mar 2022 19:33:19 +0100 (CET) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9B17F83F9B for ; Wed, 23 Mar 2022 19:33:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf33.google.com with SMTP id gi14so1950121qvb.0 for ; Wed, 23 Mar 2022 11:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C+sIVHxSLepyazQPvpT1QyFdwRdiVxTvbyw6QJUxCME=; b=kihAt9QPhNHPNugOGOrVeAbGyBC2d+B7GkAzvHZqfOLjrDgfzxlTYE+/THVSuksksL TTON7duZhzSGwFHZYcaDpjx2/kuLRy+icWqaEDeyZpEcRcGEarNZR/eQ8t4Si13LuYC8 hfDjffsTMTTydXf52S4Yinn18M2v2eAcdUn6uKJajOQg2tZh16iIAQt4uzkhbKPoDRn7 Zmh2PsptDTjbH3QgU2BXEVA3JaEOtds1qymY15R6y1NdUOBKteWhyZ/bhrXN8YTwn5CQ TaYDgfhWE8XDNvzz/Ny4EcxVA1z60OHgpbUU9R3JinBh1gtXWulWJCjsQR5YCVqxt2es aavg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C+sIVHxSLepyazQPvpT1QyFdwRdiVxTvbyw6QJUxCME=; b=MK4KmmCwkDcJfMRsIoMX86deMr5L4JjaEA0+RbxKUKIUhdTkkD6o0m3FDMxoUULLEp GSei4/27z5us3FVhjRNcVOTQFmd0P4U2iTJHJ0jNaFlF1t3zSzolQVpwMOJFVZI74LYi 0OxDHxauVj1Ckl8WxB8G30HNwIyVQ5h8ITJTLahdNSbe4rYDnudEhA71golWcuOFX8Ra imBff90/AW2gfRUHv/EdtC+a251rYFVegOiPkL6RrWqAhy6hqweW42/ks7v/K8nKjWxX t5yg58NA4iLQYjlyNiszui3XZ/DkuqUXffZW1s1ierCiHgxSIRVomm5pMDWAuGSuYrIl m1dw== X-Gm-Message-State: AOAM530uZ8hqCCTBFXkYTBqpcXCRIonC382CJHrP+xEju/lk9hio/mu3 tAcY/ngcPhxGgAcARAJqAq51xWKKJH8= X-Google-Smtp-Source: ABdhPJzED9lWEDu01k/trgPgXUJem7XfMz0XmTiHz65KGOOU4I60foNj23tzKvzJxCnewL7LXj7igA== X-Received: by 2002:ad4:53c5:0:b0:429:d6fb:f0a0 with SMTP id k5-20020ad453c5000000b00429d6fbf0a0mr1171919qvv.108.1648060393979; Wed, 23 Mar 2022 11:33:13 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id t7-20020a05622a01c700b002e1b3555c2fsm564110qtw.26.2022.03.23.11.33.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 11:33:13 -0700 (PDT) Subject: Re: [PATCH v2] board: kontron: increase the CONFIG_SYS_MALLOC_F_LEN To: Heiko Thiery , Simon Glass Cc: Heinrich Schuchardt , Tom Rini , Stefano Babic , Fabio Estevam , Peng Fan , U-Boot Mailing List References: <20220321142631.63704-1-heiko.thiery@gmail.com> From: Sean Anderson Message-ID: <19e21ec5-184b-10d9-9bee-8ece6dc58095@gmail.com> Date: Wed, 23 Mar 2022 14:33:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/23/22 2:26 PM, Heiko Thiery wrote: > Hi Simon, >=20 > Am Mi., 23. M=C3=A4rz 2022 um 19:04 Uhr schrieb Simon Glass : >> >> Hi Heinrich, >> >> On Tue, 22 Mar 2022 at 03:25, Heinrich Schuchardt = wrote: >>> >>> On 3/21/22 15:26, Heiko Thiery wrote: >>>> It was observed that enabling additional DM modules the configured >>>> malloc value is not sufficient. So lets increase the value. >>>> >>>> Signed-off-by: Heiko Thiery >>>> --- >>>> v2: >>>> - add a more proper commit message to explan why the value was in= creased >>>> >>>> configs/kontron_pitx_imx8m_defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/configs/kontron_pitx_imx8m_defconfig b/configs/kontron_= pitx_imx8m_defconfig >>>> index 76430213e3..30c3586937 100644 >>>> --- a/configs/kontron_pitx_imx8m_defconfig >>>> +++ b/configs/kontron_pitx_imx8m_defconfig >>>> @@ -2,6 +2,7 @@ CONFIG_ARM=3Dy >>>> CONFIG_ARCH_IMX8M=3Dy >>>> CONFIG_SYS_TEXT_BASE=3D0x40200000 >>>> CONFIG_SYS_MALLOC_LEN=3D0x600000 >>>> +CONFIG_SYS_MALLOC_F_LEN=3D0x10000 >>> >>> @Heiko >>> Should we really adjust this on board level? Won't we have the same >>> problem on all imx8m boards? >>> >>> Why don't you change the default for all i.mx8 boards in /Kconfig? >>> >>> @Tom, @Simon >>> Shouldn't we replace the default of 0x400 by 0x2000 generally? >> >> I don't think that is a good idea. That is a lot of memory! Many >> platforms don't need that much. >> >> I wonder what is driving this large amount. Is it pinctrl? >=20 > The increase comes from the introduction of a clock driver for the > imx8mq platform. Yes, the problem is that CCF creates a udevice+clk+private data for every clock. This runs about 150-200 bytes per clock on a 64-bit platform. In addition, many physical clocks are modeled as several logical clocks plus a composite. This means a platform with maybe 20-30 physical clocks can easily allocate 10k-20k to create the clock tree. --Sean