From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61667EB64D7 for ; Thu, 22 Jun 2023 01:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjFVBme (ORCPT ); Wed, 21 Jun 2023 21:42:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjFVBmc (ORCPT ); Wed, 21 Jun 2023 21:42:32 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1904CEC; Wed, 21 Jun 2023 18:42:31 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1b512309c86so1043285ad.1; Wed, 21 Jun 2023 18:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687398150; x=1689990150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XPACPjybs01Q+xtyqR1I7Lb0wmi+vfdHQMuD/c6ZGUE=; b=bngSy2EBWoU3OeFsbDA+eyJ5e2IYxEDNg12uoa7PlUI0k8k6aI5VRD3Pjad75jQBfB N6bZC+GjRkhJs8OllpcuGGEJdPgdg8FHLnVVOAhmoua4nCRnmPBtC67AwLMr80VOwiW3 miAqh5Yajefq+VI0WW7l6jpVV3fN3vCn7OPgcq6CiqkwxhoiMygvoOKrHMbnVwhTpIZO Z9KCFWS2oh6ts+4twaRTWE/n9zYvRRmqp4BWQiD+XtQynCaXhcbHtvJEV3fWEBkhM2zb u48adqL89CNvtY5RXq+mADj0zpsWYqgXwvQpVecOOwvw/c5KBfS18FRVmkQhJafCT/dy m8ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687398150; x=1689990150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XPACPjybs01Q+xtyqR1I7Lb0wmi+vfdHQMuD/c6ZGUE=; b=TLKmY4l9j9ZsbWxd817ktbb7dYWA3P+AChDgWuO0yw1qHIaj3CpbHj6tsq3+x6t33C Lc4j2Rf+5lk8WErxMr64BVIcpHD9BqDYyz3rgxpTktb9afF9r/XfrEyzBxz0GSelYVuz Ww54h/g9zfHuzWrIaKkepKSlk+ifEXYSSGSRklqGKqhrn5cRaZoLBbk709AGR3qVDhxN Q9Xv5iNOLY87F5QSbxqZBYGNe9hSEZk3Q0YGv1x68wHzq9dVHv1eXP4mnbfufystJ98O TG1pVmQ0I6plTaFViCXh0aFXi4BEeoqgPvDnNPEIq5V7fZbN6MH1EZ0Q0EnTDZzZIKbc iu5g== X-Gm-Message-State: AC+VfDyBANDCc6a/GJbu058Zt2X+WGHxC4oJSfUolO168GhtsLXp31Tf uLeAJJBlkzN11TjEIDr5LOc= X-Google-Smtp-Source: ACHHUZ5Ff+IphUW2rYFGb2whpUNS3ECx0FQJgwQ/+Sw++jToh5zX/zQLKACFbnhzounRrYJv0N6QpA== X-Received: by 2002:a17:902:bc43:b0:1b6:8233:6f5c with SMTP id t3-20020a170902bc4300b001b682336f5cmr6683859plz.19.1687398150365; Wed, 21 Jun 2023 18:42:30 -0700 (PDT) Received: from [192.168.1.101] (1-160-168-200.dynamic-ip.hinet.net. [1.160.168.200]) by smtp.gmail.com with ESMTPSA id n10-20020a170902e54a00b001b3d6088993sm4118057plf.24.2023.06.21.18.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 18:42:29 -0700 (PDT) Message-ID: <19e93057-46e4-1578-9e3e-138bd09cccfc@gmail.com> Date: Thu, 22 Jun 2023 09:42:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions To: Arnd Bergmann , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, soc@kernel.org, krzysztof.kozlowski+dt@linaro.org, schung@nuvoton.com, Jacky Huang References: <20230621031605.234149-1-ychuang570808@gmail.com> <20230621031605.234149-2-ychuang570808@gmail.com> <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com> Content-Language: en-US From: Jacky Huang In-Reply-To: <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2023/6/21 下午 10:22, Arnd Bergmann wrote: > On Wed, Jun 21, 2023, at 05:16, Jacky Huang wrote: >> From: Jacky Huang >> >> Moved the declaration of extern functions ma35d1_reg_clk_pll() and >> ma35d1_reg_adc_clkdiv() from the .c files to the newly created header >> file clk-ma35d1.h. >> >> Signed-off-by: Jacky Huang > >> #define PLL_MAX_NUM 5 >> @@ -20,19 +22,19 @@ static DEFINE_SPINLOCK(ma35d1_lock); >> #define REG_CLK_PWRCTL 0x00 >> #define REG_CLK_SYSCLK0 0x04 >> #define REG_CLK_SYSCLK1 0x08 >> -#define REG_CLK_APBCLK0 0x0C >> +#define REG_CLK_APBCLK0 0x0c >> #define REG_CLK_APBCLK1 0x10 >> #define REG_CLK_APBCLK2 0x14 >> #define REG_CLK_CLKSEL0 0x18 >> -#define REG_CLK_CLKSEL1 0x1C >> +#define REG_CLK_CLKSEL1 0x1c >> #define REG_CLK_CLKSEL2 0x20 >> #define REG_CLK_CLKSEL3 0x24 >> #define REG_CLK_CLKSEL4 0x28 >> -#define REG_CLK_CLKDIV0 0x2C >> +#define REG_CLK_CLKDIV0 0x2c >> #define REG_CLK_CLKDIV1 0x30 >> #define REG_CLK_CLKDIV2 0x34 >> #define REG_CLK_CLKDIV3 0x38 >> -#define REG_CLK_CLKDIV4 0x3C >> +#define REG_CLK_CLKDIV4 0x3c >> #define REG_CLK_CLKOCTL 0x40 >> #define REG_CLK_STATUS 0x50 >> #define REG_CLK_PLL0CTL0 0x60 > This part of the patch does not relate to the decription, it > looks like a minor cleanup that should be a separate patch. > > The actual change looks good and required, but I can't apply it > if it's mixed with unrelated changes like this. > > Arnd Dear Arnd, Thanks for the advice. I will extract the unrelated parts from this patch and create another patch for them. Best Regards, Jacky Huang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA6F2EB64D7 for ; Thu, 22 Jun 2023 01:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iop1wetb4IO67XRUBU4ux6A2O1UWw+wwMBOhJnyHWc4=; b=YOWoumUjTNsrNP 5hGlpfmodvQuni0oHRNnDl8MJydw5byFy4J3RA51aFsmyYMyhbOWD562IXFutgrLk0GNLaJ5rlO0d S3yEpaF6INn9SyI8qfjM4BORmyFyLW4yFQui7rerHwv9oKlRmar5tXICg1SYbbOrRd1nqXV1by059 6ZOWX6/OAL3X5W+YI2oLrrS76J8mo/IGKz4Em72umwpZqhIInDe/n+Rs1YNzM64ifHhFYl9mNwAPj PbcC86flS4DRMJP+wuS8Hznwa5KX1qCcjJGiIxG0Go0Ri4gVg51lKV2K/Z52vVNfS4rRo/Emk4rZe yWfNPd+pQcTjkkaBZRjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qC9LQ-00GPDR-2u; Thu, 22 Jun 2023 01:42:44 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qC9LG-00GP7P-2Q for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 01:42:36 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1b539d2f969so1108125ad.0 for ; Wed, 21 Jun 2023 18:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687398150; x=1689990150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XPACPjybs01Q+xtyqR1I7Lb0wmi+vfdHQMuD/c6ZGUE=; b=bngSy2EBWoU3OeFsbDA+eyJ5e2IYxEDNg12uoa7PlUI0k8k6aI5VRD3Pjad75jQBfB N6bZC+GjRkhJs8OllpcuGGEJdPgdg8FHLnVVOAhmoua4nCRnmPBtC67AwLMr80VOwiW3 miAqh5Yajefq+VI0WW7l6jpVV3fN3vCn7OPgcq6CiqkwxhoiMygvoOKrHMbnVwhTpIZO Z9KCFWS2oh6ts+4twaRTWE/n9zYvRRmqp4BWQiD+XtQynCaXhcbHtvJEV3fWEBkhM2zb u48adqL89CNvtY5RXq+mADj0zpsWYqgXwvQpVecOOwvw/c5KBfS18FRVmkQhJafCT/dy m8ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687398150; x=1689990150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XPACPjybs01Q+xtyqR1I7Lb0wmi+vfdHQMuD/c6ZGUE=; b=JizUPeXA8Ej3SgEhCHUPB6K400YZjjbPeLW9hLFvJ2v7EOs8fNOjMDeJNJ0ZjO8GLW wK3tF1U09NGXLaUBcLNLqUQwIBCwubz/egcBwmd76APFacUA7V5/FyoJ5V7jnzZpoJx8 VPcaD8wpy7hUhNjNZJZDmITpwt4KHyoDazxHKPrXlPg6V/SsLv21cav9SCeZXRzeFKfw CJalESlaIgd1WARZNCYYt36KEGlNx0eXuo4DxKGOEhDViGEuFXwnnrrMKnYZSomfA74m Hr+hi8UiTtkEUlYddAcwyn1E/X2VnOVwwvxe+1+cgP9LZmpJplNSTloc/Ybeid24Rdj4 noaQ== X-Gm-Message-State: AC+VfDwXh/KxrEIPs+LpfT2HvX1HiTp5jV/GzwBvtCagvpzpcE1SLb5T o0HsATSAKqWeIku8HKVdtIs= X-Google-Smtp-Source: ACHHUZ5Ff+IphUW2rYFGb2whpUNS3ECx0FQJgwQ/+Sw++jToh5zX/zQLKACFbnhzounRrYJv0N6QpA== X-Received: by 2002:a17:902:bc43:b0:1b6:8233:6f5c with SMTP id t3-20020a170902bc4300b001b682336f5cmr6683859plz.19.1687398150365; Wed, 21 Jun 2023 18:42:30 -0700 (PDT) Received: from [192.168.1.101] (1-160-168-200.dynamic-ip.hinet.net. [1.160.168.200]) by smtp.gmail.com with ESMTPSA id n10-20020a170902e54a00b001b3d6088993sm4118057plf.24.2023.06.21.18.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 18:42:29 -0700 (PDT) Message-ID: <19e93057-46e4-1578-9e3e-138bd09cccfc@gmail.com> Date: Thu, 22 Jun 2023 09:42:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions To: Arnd Bergmann , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, soc@kernel.org, krzysztof.kozlowski+dt@linaro.org, schung@nuvoton.com, Jacky Huang References: <20230621031605.234149-1-ychuang570808@gmail.com> <20230621031605.234149-2-ychuang570808@gmail.com> <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com> Content-Language: en-US From: Jacky Huang In-Reply-To: <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_184234_798374_066BB389 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjMvNi8yMSDkuIvljYggMTA6MjIsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gT24gV2Vk LCBKdW4gMjEsIDIwMjMsIGF0IDA1OjE2LCBKYWNreSBIdWFuZyB3cm90ZToKPj4gRnJvbTogSmFj a3kgSHVhbmcgPHljaHVhbmczQG51dm90b24uY29tPgo+Pgo+PiBNb3ZlZCB0aGUgZGVjbGFyYXRp b24gb2YgZXh0ZXJuIGZ1bmN0aW9ucyBtYTM1ZDFfcmVnX2Nsa19wbGwoKSBhbmQKPj4gbWEzNWQx X3JlZ19hZGNfY2xrZGl2KCkgZnJvbSB0aGUgLmMgZmlsZXMgdG8gdGhlIG5ld2x5IGNyZWF0ZWQg aGVhZGVyCj4+IGZpbGUgY2xrLW1hMzVkMS5oLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKYWNreSBI dWFuZyA8eWNodWFuZzNAbnV2b3Rvbi5jb20+Cj4KPj4gICAjZGVmaW5lIFBMTF9NQVhfTlVNCQk1 Cj4+IEBAIC0yMCwxOSArMjIsMTkgQEAgc3RhdGljIERFRklORV9TUElOTE9DSyhtYTM1ZDFfbG9j ayk7Cj4+ICAgI2RlZmluZSBSRUdfQ0xLX1BXUkNUTAkJMHgwMAo+PiAgICNkZWZpbmUgUkVHX0NM S19TWVNDTEswCQkweDA0Cj4+ICAgI2RlZmluZSBSRUdfQ0xLX1NZU0NMSzEJCTB4MDgKPj4gLSNk ZWZpbmUgUkVHX0NMS19BUEJDTEswCQkweDBDCj4+ICsjZGVmaW5lIFJFR19DTEtfQVBCQ0xLMAkJ MHgwYwo+PiAgICNkZWZpbmUgUkVHX0NMS19BUEJDTEsxCQkweDEwCj4+ICAgI2RlZmluZSBSRUdf Q0xLX0FQQkNMSzIJCTB4MTQKPj4gICAjZGVmaW5lIFJFR19DTEtfQ0xLU0VMMAkJMHgxOAo+PiAt I2RlZmluZSBSRUdfQ0xLX0NMS1NFTDEJCTB4MUMKPj4gKyNkZWZpbmUgUkVHX0NMS19DTEtTRUwx CQkweDFjCj4+ICAgI2RlZmluZSBSRUdfQ0xLX0NMS1NFTDIJCTB4MjAKPj4gICAjZGVmaW5lIFJF R19DTEtfQ0xLU0VMMwkJMHgyNAo+PiAgICNkZWZpbmUgUkVHX0NMS19DTEtTRUw0CQkweDI4Cj4+ IC0jZGVmaW5lIFJFR19DTEtfQ0xLRElWMAkJMHgyQwo+PiArI2RlZmluZSBSRUdfQ0xLX0NMS0RJ VjAJCTB4MmMKPj4gICAjZGVmaW5lIFJFR19DTEtfQ0xLRElWMQkJMHgzMAo+PiAgICNkZWZpbmUg UkVHX0NMS19DTEtESVYyCQkweDM0Cj4+ICAgI2RlZmluZSBSRUdfQ0xLX0NMS0RJVjMJCTB4MzgK Pj4gLSNkZWZpbmUgUkVHX0NMS19DTEtESVY0CQkweDNDCj4+ICsjZGVmaW5lIFJFR19DTEtfQ0xL RElWNAkJMHgzYwo+PiAgICNkZWZpbmUgUkVHX0NMS19DTEtPQ1RMCQkweDQwCj4+ICAgI2RlZmlu ZSBSRUdfQ0xLX1NUQVRVUwkJMHg1MAo+PiAgICNkZWZpbmUgUkVHX0NMS19QTEwwQ1RMMAkweDYw Cj4gVGhpcyBwYXJ0IG9mIHRoZSBwYXRjaCBkb2VzIG5vdCByZWxhdGUgdG8gdGhlIGRlY3JpcHRp b24sIGl0Cj4gbG9va3MgbGlrZSBhIG1pbm9yIGNsZWFudXAgdGhhdCBzaG91bGQgYmUgYSBzZXBh cmF0ZSBwYXRjaC4KPgo+IFRoZSBhY3R1YWwgY2hhbmdlIGxvb2tzIGdvb2QgYW5kIHJlcXVpcmVk LCBidXQgSSBjYW4ndCBhcHBseSBpdAo+IGlmIGl0J3MgbWl4ZWQgd2l0aCB1bnJlbGF0ZWQgY2hh bmdlcyBsaWtlIHRoaXMuCj4KPiAgICAgIEFybmQKCkRlYXIgQXJuZCwKCgpUaGFua3MgZm9yIHRo ZSBhZHZpY2UuCgpJIHdpbGwgZXh0cmFjdCB0aGUgdW5yZWxhdGVkIHBhcnRzIGZyb20gdGhpcyBw YXRjaCBhbmQgY3JlYXRlIGFub3RoZXIgCnBhdGNoIGZvciB0aGVtLgoKCkJlc3QgUmVnYXJkcywK CkphY2t5IEh1YW5nCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK