All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Ho Jie Feng <hjf3108@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH rtw-next v4 3/7] wifi: rtw88: correctly expose beamformee capabilities
Date: Sun, 15 Nov 2026 14:37:46 +0100	[thread overview]
Message-ID: <1F34F485-2BCF-4285-9C7C-189DF4E5FED9@linux.dev> (raw)
In-Reply-To: <20261115114336.1739863-4-hjf3108@gmail.com>

Hi Jie Feng,

Thanks for the patch. One comment on the description below.

On November 15, 2026 12:43:29 PM GMT+01:00, Ho Jie Feng <hjf3108@gmail.com>
wrote:

> Implement beamformee support for 88xxa since they have
> support for it.

Could you expand this a little to explain what was missing? As far as I
can see, the chips had no config_bfee callback, and this adds the SU
beamformee setup for RTL8812A, RTL8821A and RTL8814A.

I think a short explanation of the sounding and CSI report setup would
make the change easier to follow.

Best regards,
Luka Gejak

  parent reply	other threads:[~2026-11-15 13:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 11:43 [PATCH rtw-next v4 0/7] wifi: rtw88: extend 88xxA support Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions Ho Jie Feng
2026-11-15 13:35   ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 2/7] wifi: rtw88: skip the dynamic CSI rate without a cfg_csi_rate op Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 3/7] wifi: rtw88: correctly expose beamformee capabilities Ho Jie Feng
2026-11-15 13:20   ` Luka Gejak
2026-11-15 13:36   ` Luka Gejak
2026-11-15 13:37   ` Luka Gejak [this message]
2026-11-15 13:39     ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 4/7] wifi: rtw88: 88xxa: receive VHT SU beamformed transmissions Ho Jie Feng
2026-11-15 11:43 ` [PATCH rtw-next v4 5/7] wifi: rtw88: prepare frequency-offset correction for more chips Ho Jie Feng
2026-11-15 13:41   ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 6/7] wifi: rtw88: 88xxa: correct carrier-frequency offset Ho Jie Feng
2026-11-15 13:20   ` Luka Gejak
2026-11-15 13:42   ` Luka Gejak
2026-11-15 11:43 ` [PATCH rtw-next v4 7/7] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits Ho Jie Feng
2026-11-15 13:43   ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1F34F485-2BCF-4285-9C7C-189DF4E5FED9@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=hjf3108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.