From: Mikko Perttunen <mperttunen@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>, linux-media@vger.kernel.org
Cc: "Karl Mehltretter" <kmehltretter@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Philipp Stanner" <phasta@kernel.org>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org,
"Karl Mehltretter" <kmehltretter@gmail.com>
Subject: Re: [PATCH v2] drm/tegra: Fix dma-buf reference on import errors
Date: Thu, 19 Nov 2026 15:26:15 +0900 [thread overview]
Message-ID: <1IgFo7YmReCFJ-7dn7J0mw@nvidia.com> (raw)
In-Reply-To: <20261031104439.91346-1-kmehltretter@gmail.com>
On Saturday, October 31, 2026 7:44 PM Karl Mehltretter wrote:
> tegra_bo_import() takes its own dma-buf reference only on success, but if
> mapping fails, its detach error path still calls dma_buf_put(). That drops
> the reference held by the PRIME caller, which then puts it again, and can
> release the dma-buf file while its descriptor is still installed:
>
> VFS: Close: file count is 0 (f_op=dma_buf_fops)
>
> Remove the unmatched put.
>
> Fixes: f5b8794e17e4 ("drm/tegra: gem: Don't attach dma-bufs when not needed")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> v2: Clean up the commit message (Mikko). No code change.
> v1: https://lore.kernel.org/r/20261026055842.96484-1-kmehltretter@gmail.com/
>
> Tested on a Jetson Nano (p3450-0000) with CONFIG_DMABUF_DEBUG=y and a local
> change that rejects zero-byte IOMMU mappings to force the error path. Without
> this patch the forced failure produced the warning above. With it, 100
> consecutive failures returned -EINVAL, kept the original dma-buf fd and left
> no dma-buf objects.
>
> drivers/gpu/drm/tegra/gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index f76af73..ed35a34 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -502,7 +502,6 @@ detach:
> dma_buf_unmap_attachment_unlocked(attach, bo->sgt, DMA_TO_DEVICE);
>
> dma_buf_detach(buf, attach);
> - dma_buf_put(buf);
> free:
> drm_gem_object_release(&bo->gem);
> kfree(bo);
>
> base-commit: 21a7f44fd0765fcc5194130b28767786eba1d1e7
> --
> 2.39.5 (Apple Git-154)
>
>
Thank you
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
prev parent reply other threads:[~2026-11-19 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 10:44 [PATCH v2] drm/tegra: Fix dma-buf reference on import errors Karl Mehltretter
2026-11-19 6:26 ` Mikko Perttunen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1IgFo7YmReCFJ-7dn7J0mw@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=kmehltretter@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.