From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A58B7C433EF for ; Tue, 14 Dec 2021 06:36:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.246391.424915 (Exim 4.92) (envelope-from ) id 1mx1Pr-0005c9-3k; Tue, 14 Dec 2021 06:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 246391.424915; Tue, 14 Dec 2021 06:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mx1Pq-0005ai-VD; Tue, 14 Dec 2021 06:35:58 +0000 Received: by outflank-mailman (input) for mailman id 246391; Tue, 14 Dec 2021 06:35:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mx1Pp-0005aG-P6 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 06:35:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 175d0cab-5ca8-11ec-9e60-abaf8a552007; Tue, 14 Dec 2021 07:35:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA2C61F3C3; Tue, 14 Dec 2021 06:35:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8126D13A1E; Tue, 14 Dec 2021 06:35:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d5SZHUs7uGGNZAAAMHmgww (envelope-from ); Tue, 14 Dec 2021 06:35:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 175d0cab-5ca8-11ec-9e60-abaf8a552007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1639463755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c2zscTZWCfdTnNvE2ycq2IkmlOcYS06khPxhTTuwdj8=; b=KqIm74P6gtnRbBc1mgJyFbB+sJxsnlM9IdzCdWz3CfZc5hYBu+GpjoEaThguP0yxq2waGU pmYVk298mMlGRNQq4MJSs4KtswGYtW5rybV9A0PVP7B2tv4rwuBTwxaauPEvNoXl9Ii1EZ cXMYd9FGA4rBv5H124TNY+snzGWfx/c= Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20211206072337.9517-1-jgross@suse.com> <20211206072337.9517-4-jgross@suse.com> <20211212001542.qhz7wfdwq7k5ymxr@begin> <20211213212206.htg4eykr32x63swk@begin> From: Juergen Gross Message-ID: <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com> Date: Tue, 14 Dec 2021 07:35:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20211213212206.htg4eykr32x63swk@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="llBbEvctv1ssYaQy46gzgggqDbLQTwPwo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --llBbEvctv1ssYaQy46gzgggqDbLQTwPwo Content-Type: multipart/mixed; boundary="EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com> Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode References: <20211206072337.9517-1-jgross@suse.com> <20211206072337.9517-4-jgross@suse.com> <20211212001542.qhz7wfdwq7k5ymxr@begin> <20211213212206.htg4eykr32x63swk@begin> In-Reply-To: <20211213212206.htg4eykr32x63swk@begin> --EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua Content-Type: multipart/mixed; boundary="------------347B5882F2F1F0BAC21C4DBE" Content-Language: en-US This is a multi-part message in MIME format. --------------347B5882F2F1F0BAC21C4DBE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 13.12.21 22:22, Samuel Thibault wrote: > Juergen Gross, le lun. 13 d=C3=A9c. 2021 15:58:58 +0100, a ecrit: >> On 12.12.21 01:15, Samuel Thibault wrote: >>> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:30 +0100, a ecrit: >>>> - unsigned long pfn, max =3D 0; >>>> + unsigned long pfns, max =3D 0; >>> >>> I'd say rather rename max to start. >>> >>>> e820_get_memmap(); >>>> @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void) >>>> { >>>> if ( e820_map[i].type !=3D E820_RAM ) >>>> continue; >>>> - pfn =3D (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT= ; >>>> - if ( pfn > max ) >>>> - max =3D pfn; >>>> + pfns =3D e820_map[i].size >> PAGE_SHIFT; >>>> + max =3D e820_map[i].addr >> PAGE_SHIFT; >>> >>> since it's it's always the start of the e820 entry. >>> >>>> + if ( pages <=3D pfns ) >>>> + return max + pages; >>>> + pages -=3D pfns; >>>> + max +=3D pfns; >>> >>> Here we don't need do change max, only pages. >> >> It is needed in case the loop is finished. >> >> And this was the reason for naming it max. >=20 > Ah, ok. >=20 > At first read the name was confusing me. Perhaps better use two > variables then: start and max, so that we have >=20 > start =3D e820_map[i].addr >> PAGE_SHIFT; > if ( pages <=3D pfns ) > return start + pages; > pages -=3D pfns; > max =3D start + pfns; Hmm, or I can rename max to start, drop the "max +=3D pfns;" and do a "return start + pfns;" at the end of the function. Juergen --------------347B5882F2F1F0BAC21C4DBE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------347B5882F2F1F0BAC21C4DBE-- --EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua-- --llBbEvctv1ssYaQy46gzgggqDbLQTwPwo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG4O0oFAwAAAAAACgkQsN6d1ii/Ey/b PAf+IWE544eHGTWaSvvHe0MkZgPT+JFOlO5xNTc1nASvtqDWqg4o2F4RkLvdo+xYl6eHrlCLnhHG ai3rSdYA6PMdU3EVoAzqW/p1xHgG9z1GG3Fpw+/rEVytNaSMyzQFUi9TuPTAsXYkKa0gU5hfBVCb 17UISZtNemtIeCOwl5jhe6o79A3EUXg8m4flZiWWJF+XboF4P3bs8wyXU3R2bCDSaC6jZcxkdE4Q dljL4TJAxBUHTLs0Iwu09zWoWIxhiyKdVoHeyGQVqThvyGmfw8rCJf9PxgzA02sNgqz1LXEpAgRU xf3B9wMF8N+Uto2uvLMvVFZjxnaQhsZE7QjTfWcQ5g== =vFNO -----END PGP SIGNATURE----- --llBbEvctv1ssYaQy46gzgggqDbLQTwPwo--