Re: [PATCH] trivial fix for vcpu_set_affinity

[Emmanuel Ackaouy <ack@xensource.com>]

I don't get it.

If you don't at least call vcpu_sleep_nosync() on the current context
when it changes affinity, how do you initiate a reschedule event?

What's wrong with the code as is?

On Jan 11, 2007, at 9:42, Tian, Kevin wrote:

> No need to try migration in current context since self migrate
> will be handled by next vcpu after context switch.
>
> Signed-off-by Kevin Tian <kevin.tian@intel.com>
>
> diff -r e66f047bc97e xen/common/schedule.c
> --- a/xen/common/schedule.c	Tue Jan 09 18:56:44 2007 -0800
> +++ b/xen/common/schedule.c	Thu Jan 11 16:31:37 2007 +0800
> @@ -243,7 +243,7 @@ int vcpu_set_affinity(struct vcpu *v, cp
>
>      vcpu_schedule_unlock_irqrestore(v, flags);
>
> -    if ( test_bit(_VCPUF_migrating, &v->vcpu_flags) )
> +    if ( (v != current) && test_bit(_VCPUF_migrating, &v->vcpu_flags) 
> )
>      {
>          vcpu_sleep_nosync(v);
>          vcpu_migrate(v);
>
> Thanks,
> Kevin
> <set_affinity.patch>_______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel