Re: [PATCH v5 4/8] hw/vfio: eradicate CONFIG_IOMMU from sources

["Cédric Le Goater" <clg@redhat.com>]

On 3/18/26 18:47, Pierrick Bouvier wrote:
> This commit removes usage of CONFIG_IOMMU in hw/vfio sources, exposing
> inconditionally iommufd related properties, which are declared
> statically (in const arrays). The alternative to expose them dynamically
> is more complex and requires boilerplate to set properties at runtime,
> with set_* callbacks and added logic to check if iommufd backend is
> available, with no obvious benefit.
> 
> One possible difference is that user may see a different error message
> when trying to attach a vfio device with a QEMU not supporting iommufd,
> without declaring iommufd object associated.
> 
> Instead of:
> ```
> $ qemu-system-* -device vfio-pci,host=0000:01:00.0,iommufd=iommufd0
> qemu-system-*: -device vfio-pci,host=0000:01:00.0,iommufd=iommufd0: Property 'vfio-pci.iommufd' not found
> ```
> User will now see:
> ```
> qemu-system-aarch64: -device vfio-pci,host=0000:01:00.0,iommufd=iommufd0: Device 'iommufd0' not found
> ```
> 
> However, since declaring the iommufd object is needed, error reported
> before and after is still the same:
> ```
> $ qemu-system-* -object iommufd,id=iommufd0 -device vfio-pci,host=0000:01:00.0,iommufd=iommufd0
> qemu-system-*: invalid object type: iommufd
> ```
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/vfio/ap.c  |  9 ---------
>   hw/vfio/ccw.c |  9 ---------
>   hw/vfio/pci.c | 11 -----------
>   3 files changed, 29 deletions(-)



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.