From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6810BC433E6 for ; Mon, 1 Mar 2021 10:26:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1223764E10 for ; Mon, 1 Mar 2021 10:26:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1223764E10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 545146E588; Mon, 1 Mar 2021 10:26:08 +0000 (UTC) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00F496E581 for ; Mon, 1 Mar 2021 10:26:06 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 01 Mar 2021 02:26:06 -0800 Received: from [10.2.62.164] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Mar 2021 10:26:01 +0000 Message-ID: <1aabe37b-d79b-8456-641d-aaf8fe2c330d@nvidia.com> Date: Mon, 1 Mar 2021 02:26:01 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Subject: Re: [PATCH 2/2] drm/etnaviv: User FOLL_LONGTERM in userptr Content-Language: en-US To: Daniel Vetter , DRI Development References: <20210301095254.1946084-1-daniel.vetter@ffwll.ch> <20210301095254.1946084-2-daniel.vetter@ffwll.ch> From: John Hubbard In-Reply-To: <20210301095254.1946084-2-daniel.vetter@ffwll.ch> X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614594366; bh=exhNNc3pakdre3i0a0SDhUPJfxkGN1iLkxkrTKw/W94=; h=Message-ID:Date:MIME-Version:User-Agent:Subject:Content-Language: To:CC:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=UQJL1WhWok7lLJdt8zj+iHsK+qgtfEQzZzIGQc25BOTobzTDYUv6XxVNMKZfSihi6 RxqbWptCLIOHQA8hzV3OIQP921tJn0/NahYqNoiAccvhk/+TGi5bPSoWT/pqLLvkwI prg5njWpoM1QcG/4rj22qeEKotWRwDLTQxMHZ6zQhnBxhkVxj1wm/xqF4rKizebltk hSN4gSQKYmRSXZje7NC29MX3WDnSfDMbmjBgSKZgASx6t/TYJNqyJJBjGblQ+XJjEk goGU6XvY0cMBLaoESHD3vNMonMwKtafKAgLTCmBwtgXZJ+pzAjAYYpDaPuwivVB2jz fmZfA9qFsE6mQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Russell King , etnaviv@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/1/21 01:52, Daniel Vetter wrote: > There's no mmu notifier or anything like that, releasing this pin is > entirely up to userspace. Hence FOLL_LONGTERM. > > No cc: stable for this patch since a lot of the infrastructure around > FOLL_LONGETRM (like not allowing it for pages currently sitting in ^FOLL_LONGTERM > ZONE_MOVEABLE before they're migrated) is still being worked on. So > not big benefits yet. Yes. Great write-up, that's very clear, and it's exactly where we're at. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > Cc: John Hubbard > Signed-off-by: Daniel Vetter > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: etnaviv@lists.freedesktop.org > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index a9e696d05b33..db69f19ab5bc 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -689,7 +689,8 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj) > struct page **pages = pvec + pinned; > > ret = pin_user_pages_fast(ptr, num_pages, > - FOLL_WRITE | FOLL_FORCE, pages); > + FOLL_WRITE | FOLL_FORCE | FOLL_LONGTERM, > + pages); > if (ret < 0) { > unpin_user_pages(pvec, pinned); > kvfree(pvec); > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel