Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, April 20, 2021 4:09 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xiaozhen Ban
> <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control
> return value
> 
> On 3/25/2021 8:46 AM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
> >> Sent: Friday, March 19, 2021 12:08 PM
> >> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> >> <haiyue.wang@intel.com>
> >> Cc: dev@dpdk.org; stable@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return
> >> value
> >>
> >>>> -----Original Message-----
> >>>> From: Xiaozhen Ban <benhaz1024 at gmail.com>
> >>>> Sent: Thursday, March 18, 2021 19:44
> >>>> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> >>>> intel.com>
> >>>> Cc: dev at dpdk.org; stable at dpdk.org
> >>>> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> >>>>
> >>>> OK, but I think this bug affects all stable release about 6 years before
> today.
> >>
> >>> I don't think so, since it is PMD internal ops, the real API
> 'rte_flow_ops_get'
> >>> always use RTE_ETH_FILTER_GENERIC. ;-)
> >>
> >> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if
> >> application developer know how to use the parameter filter_type correctly,
> it's OK.
> >> otherwise he will get rte_eth_dev_filter_ctrl() return value is
> >> success but actually is failed.
> >
> > After check with Haiyue, we think the patch is still needed for LTS <=
> > 19.11, so
> >
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Applied to dpdk-next-net-intel.
> >
> 
> What is the status of this patch?
> It seems it did not applied, and the status in the patchwork is "Superseded".

The patch is dropped during rebase, as the function eth_igb_filter_ctrl is removed at below code refectory 
http://patchwork.dpdk.org/project/dpdk/patch/20210321090002.595744-2-thomas@monjalon.net/

this is a mistake as we still need this to be captured in LTS
unfortunately, its too late to capture it as the refectory code is already applied to main tree.

@Luca Boccassi
Could you capture this patch as an LTS only one?

Thanks
Qi