From: Akira Yokosawa <akiyks@gmail.com>
To: "Palik, Imre" <imrep.amz@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
perfbook@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Question on updated Figure 5.1 "Atomic Increment Scalability on Kaby Lake"
Date: Sun, 2 Sep 2018 17:54:57 +0900 [thread overview]
Message-ID: <1ac811fa-ad08-43aa-ac74-e6367c33e742@gmail.com> (raw)
Hello Palik,
I'm looking at Figure 5.1 of perfbook which was updated by commit
3b62f67a76e1 ("Regenerating the atomic counter graph on a more
modern CPU"), and wondering the time to increment at x = 1 looks
too small.
As is described in the Answer to Quick Quiz 5.8, atomic increment
should take a bit longer than the ideal non-atomic increment even
when the number of updaters is 1.
Or on Kaby Lake, some special optimization results in almost no
cost in this case? If that is the case, the Quick Quiz needs update...
Also, the horizontal dashed line should be closer to the x-axis,
I suppose. The time of the ideal non-atomic increment is embedded on
line 44 of CodeSamples/count/plots.sh as "8.81772".
You might need to use a proper value for Kaby Lake (should be near
zero) instead.
If I understand the circumstances right, raw data for the previous
version of the graph reside in
CodeSamples/count/data/count_atomic:u.2009.05.03a.dat.
Can you share the corresponding raw data on Kaby Lake?
Also, in the above mentioned commit, atomic125.{eps|png} were
overwritten accidentally. They were graphs of 125-thread case,
and should not have been updated IMO. They are not used in perfbook
at the moment, but I'd like to have the original ones in the repository.
If you could share the raw data for Kaby Lake, I'd be happy to fix
these issues for you.
I'm not blaming any of you. I could blame the ad-hoc design of plots.sh,
but it was written by Paul for his own use. Such scripts tend to be
ad-hoc. ;-) I might be able to improve the script.
Thanks, Akira
next reply other threads:[~2018-09-02 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 8:54 Akira Yokosawa [this message]
[not found] ` <CAFMy-Rk76bc+oOXq7ijGT4wzYkFbs1F7bkLWQ-VwE_O2Q-Z2VQ@mail.gmail.com>
2018-09-12 10:51 ` Question on updated Figure 5.1 "Atomic Increment Scalability on Kaby Lake" Akira Yokosawa
2018-09-12 10:53 ` [PATCH] CodeSamples/count: Use READ_ONCE/WRITE_ONCE in count_nonatomic.c Akira Yokosawa
2018-09-12 13:18 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac811fa-ad08-43aa-ac74-e6367c33e742@gmail.com \
--to=akiyks@gmail.com \
--cc=imrep.amz@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.