From: Aloka Dixit <alokad@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
Date: Mon, 03 Aug 2020 10:30:55 -0700 [thread overview]
Message-ID: <1aca682f4b694c5ea3d1c57291e6c196@codeaurora.org> (raw)
In-Reply-To: <6f23e2ac081a3960959f00dedcdf8795aef28a14.camel@sipsolutions.net>
On 2020-08-03 03:20, Johannes Berg wrote:
> Also,
>
>> +/**
>> + * enum nl80211_unsol_bcast_probe_resp_attributes - Unsolicited
>> broadcast probe
>> + * response configuration. Applicable only in 6GHz.
>> + *
>> + * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
>> + *
>> + * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32,
>> TU).
>> + * Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
>
> 0 doesn't make sense, you should disallow that.
>
> I see you used it for "turn off" at least in the mac80211 patch but it
> seems to me that should have a more explicit way at least in the
> external API? At the very least it needs to documentation.
>
> johannes
Hi Johannes, interval=0 means 'disable' is given in the specification,
will extend the documentation to mention that.
next prev parent reply other threads:[~2020-08-03 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 23:05 [PATCH v3 0/2] Unsolicited broadcast probe resp support Aloka Dixit
2020-07-15 23:05 ` [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support Aloka Dixit
2020-08-03 10:18 ` Johannes Berg
2020-08-03 17:28 ` Aloka Dixit
2020-08-03 10:20 ` Johannes Berg
2020-08-03 17:30 ` Aloka Dixit [this message]
2020-08-03 10:20 ` Johannes Berg
2020-08-03 10:21 ` Johannes Berg
2020-08-03 17:33 ` Aloka Dixit
2020-07-15 23:05 ` [PATCH v3 2/2] mac80211: " Aloka Dixit
2020-07-16 9:35 ` [PATCH v3 0/2] Unsolicited broadcast probe resp support Arend Van Spriel
2020-07-20 21:36 ` Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aca682f4b694c5ea3d1c57291e6c196@codeaurora.org \
--to=alokad@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.