From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Cc: steffen.klassert@secunet.com, paulb@mellanox.com, vladbu@mellanox.com
Subject: Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing
Date: Thu, 26 Sep 2019 12:05:11 -0700 [thread overview]
Message-ID: <1ad4b9f0-c9d4-954b-eafe-8652ea6ce409@gmail.com> (raw)
In-Reply-To: <20190926183705.16951-1-fw@strlen.de>
On 9/26/19 11:37 AM, Florian Westphal wrote:
> Now that we have a 3rd extension, add a new helper that drops the
> extension space and use it when we need to scrub an sk_buff.
>
> }
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index f12e8a050edb..01d65206f4fb 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -5119,7 +5119,7 @@ void skb_scrub_packet(struct sk_buff *skb, bool xnet)
> skb->skb_iif = 0;
> skb->ignore_df = 0;
> skb_dst_drop(skb);
> - secpath_reset(skb);
> + skb_ext_reset(skb);
> nf_reset(skb);
> nf_reset_trace(skb);
It is unfortunate nf_reset(skb) will call skb_ext_del(skb, SKB_EXT_BRIDGE_NF),
which is useless after skb_ext_reset(skb)
Maybe time for a nf_ct_reset() helper only dealing with nfct.
next prev parent reply other threads:[~2019-09-26 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 18:37 [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing Florian Westphal
2019-09-26 19:05 ` Eric Dumazet [this message]
2019-09-26 19:09 ` Florian Westphal
2019-09-26 19:16 ` Eric Dumazet
2019-09-27 18:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ad4b9f0-c9d4-954b-eafe-8652ea6ce409@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
--cc=steffen.klassert@secunet.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.