Re: generic/013 failure to Samba

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

I think the comment in your change is easy to understand. Looks good to me.

Steve, what do you think? I see that you have already sent the pull 
request for 6.19-rc3. Should we merge Henrique's patch in rc3?

Thanks,
ChenXiaoSong <chenxiaosong@kylinos.cn>

On 12/27/25 2:05 AM, Henrique Carvalho wrote:
> Your change does make the code semantically tighter, since ChunkCount would
> track initialized elements as we populate the array.
> 
> That said, I still slightly prefer setting ChunkCount to the allocated
> capacity before we first index Chunks[], and then setting it to the final
> chunks value before the IOCTL.
> 
> This both satisfies __counted_by_le() during population, it isn't wrong
> given the allocation is chunk_count, and avoids an extra ChunkCount
> update on every chunk entry (in my build this is not optimized away).
> It's cheap either way, but if we can avoid per-iteration overhead, I'd
> rather do so.
> 
> What do you think? Do you see any correctness or tooling downside with
> this approach?