All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Sascha Hauer <sha@pengutronix.de>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: RE: [PATCH v2] wifi: rtw88: Fix USB/SDIO devices not transmitting beacons
Date: Fri, 30 Aug 2024 00:30:04 +0000	[thread overview]
Message-ID: <1b09a87e86a344c299fe83fc38a9e323@realtek.com> (raw)
In-Reply-To: <49de73b5-698f-4865-ab63-100e28dfc4a1@gmail.com>

Hi Bitterblue, 

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> 
> All USB devices supported by rtw88 have the same problem: they don't
> transmit beacons in AP mode. (Some?) SDIO devices are also affected.
> The cause appears to be clearing BIT_EN_BCNQ_DL of REG_FWHW_TXQ_CTRL
> before uploading the beacon reserved page, so don't clear the bit for
> USB and SDIO devices.
> 
> Tested with RTL8811CU and RTL8723DU.
> 
> Cc: <stable@vger.kernel.org> # 6.6.x
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Can I say two below patchset are equivalent in your side?

[Patchset 1: your v1]
13744097 New          [1/2] wifi: rtw88: Fix USB devices not transmitting beacons
13744098 New          [2/2] wifi: rtw88: Avoid using macid 0 in AP mode

[Patchset 2: your v2 + mine]
13771597 New          [v2] wifi: rtw88: Fix USB/SDIO devices not transmitting beacons
13767746 New          wifi: rtw88: assign mac_id for vif/sta and update to TX desc

If this can make AP mode on USB devices step forward, I will merge them ahead.  



  reply	other threads:[~2024-08-30  0:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 13:11 [PATCH v2] wifi: rtw88: Fix USB/SDIO devices not transmitting beacons Bitterblue Smith
2024-08-30  0:30 ` Ping-Ke Shih [this message]
2024-08-30 10:27   ` Bitterblue Smith
2024-09-02  0:44 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b09a87e86a344c299fe83fc38a9e323@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.