All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Jonas Karlman <jonas@kwiboo.se>,
	Kever Yang <kever.yang@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Tom Rini <trini@konsulko.com>
Cc: FUKAUMI Naoki <naoki@radxa.com>, u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/3] rockchip: Add initial RK3582 support
Date: Mon, 11 Aug 2025 17:44:51 +0200	[thread overview]
Message-ID: <1b1ad33a-3004-480d-9d32-3ea05e7eaf63@cherry.de> (raw)
In-Reply-To: <20250810222644.4095072-2-jonas@kwiboo.se>

Hi Jonas,

On 8/11/25 12:26 AM, Jonas Karlman wrote:
> The RK3582 SoC is a variant of the RK3588S with some IP blocks disabled.
> What blocks are disabled/non-working is indicated by ip-state in OTP.
> 
> This add initial support for RK3582 by using ft_system_setup() to mark
> any cpu and/or vdec/venc node with status=fail as indicated by ip-state.
> 
> This apply same policy as vendor U-Boot for RK3582, i.e. two big cpu
> cores and one vdec/venc core is always failed/disabled.
> 
> Enable Kconfig option OF_SYSTEM_SETUP in board defconfig to make use of
> the required DT fixups for RK3582 board variants.
> 
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> Changes in v3:
> - Apply same policy for RK3582/RK3583 to match vendor U-Boot
>    linux-6.1-stan-rkr6 tag, allow use of the GPU and one vdec core.

Isn't the GPU supposed to be possibly non-fonctional on RK3582/RK3583? 
If we don't disable it in the DT, how will the system actually behave?

@Kever may have more official info on that?

See remarks on v2 otherwise, most of them still apply.

> - Update rkvdec node name to match latest mainling Linux DT patches.

Should we rather wait for the patches to be actually merged before 
trying to patch the device tree nodes that do not exist yet?

Cheers,
Quentin

  reply	other threads:[~2025-08-11 15:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-10 22:26 [PATCH v3 0/3] rockchip: Add initial RK3582 support Jonas Karlman
2025-08-10 22:26 ` [PATCH v3 1/3] " Jonas Karlman
2025-08-11 15:44   ` Quentin Schulz [this message]
2025-08-11 17:09     ` Jonas Karlman
2025-08-11 17:12       ` Quentin Schulz
2025-08-17 14:30     ` Kever Yang
2025-08-10 22:26 ` [PATCH v3 2/3] rockchip: rk3588-generic: Enable support for RK3582 Jonas Karlman
2025-08-10 22:26 ` [PATCH v3 3/3] rockchip: rk3588s-rock-5c: Add support for ROCK 5C Lite variant Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1ad33a-3004-480d-9d32-3ea05e7eaf63@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=naoki@radxa.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.