Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/i915/i915_pm_dc: Refactoring pwr_dmn_info to debugfs_dump

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Bhatt, Jigar <jigar.bhatt@intel.com>
> Sent: Friday, September 24, 2021 3:33 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Bhatt, Jigar <jigar.bhatt@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; Varide, Nischal <nischal.varide@intel.com>;
> Shankar, Uma <uma.shankar@intel.com>; Sharma, Swati2
> <swati2.sharma@intel.com>
> Subject: [PATCH i-g-t v2 1/2] tests/i915/i915_pm_dc: Refactoring pwr_dmn_info
> to debugfs_dump
Please fix the version number here.
With that.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
> 
> Refactoring pwr_dmn_info to debugfs_dump so other test can use it for
> dumping debugfs file.[Anshuman]
> 
> Signed-off-by: Jigar Bhatt <jigar.bhatt@intel.com>
> ---
>  tests/i915/i915_pm_dc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> 9d0a15d8..04acf839 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -50,7 +50,7 @@ typedef struct {
>  	int msr_fd;
>  	int debugfs_fd;
>  	uint32_t devid;
> -	char *pwr_dmn_info;
> +	char *debugfs_dump;
>  	igt_display_t display;
>  	struct igt_fb fb_white, fb_rgb, fb_rgr;
>  	enum psr_mode op_psr_mode;
> @@ -217,7 +217,7 @@ static void check_dc_counter(data_t *data, int dc_flag,
> uint32_t prev_dc_count)
>  		(dc_flag & CHECK_DC5 ? "DC5" : "DC6"));
>  	igt_assert_f(dc_state_wait_entry(data->debugfs_fd, dc_flag,
> prev_dc_count),
>  		     "%s state is not achieved\n%s:\n%s\n", tmp,
> PWR_DOMAIN_INFO,
> -		     data->pwr_dmn_info = igt_sysfs_get(data->debugfs_fd,
> PWR_DOMAIN_INFO));
> +		     data->debugfs_dump = igt_sysfs_get(data->debugfs_fd,
> +PWR_DOMAIN_INFO));
>  }
> 
>  static void setup_videoplayback(data_t *data) @@ -504,7 +504,7 @@ int
> main(int argc, char *argv[])
>  	}
> 
>  	igt_fixture {
> -		free(data.pwr_dmn_info);
> +		free(data.debugfs_dump);
>  		close(data.debugfs_fd);
>  		close(data.msr_fd);
>  		display_fini(&data);
> --
> 2.25.1