Re: [PATCH RESEND net-next v4 2/4] sfc: allow insertion of filters for unicast PTP

[Edward Cree <ecree.xilinx@gmail.com>]

On 14/03/2023 10:09, Íñigo Huguet wrote:
> Add a second list for unicast filters and generalize the
> efx_ptp_insert/remove_filters functions to allow acting in any of the 2
> lists.
> 
> No filters for unicast are inserted yet. That will be done in the next
> patch.
> 
> The reason to use 2 different lists instead of a single one is that, in
> next patches, we will want to check if unicast filters are already added
> and if they're expired. We don't need that for multicast filters.
> 
> Reported-by: Yalin Li <yalli@redhat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>

Acked-by: Edward Cree <ecree.xilinx@gmail.com>

> -static void efx_ptp_remove_multicast_filters(struct efx_nic *efx)
> +static void efx_ptp_remove_filters(struct efx_nic *efx,
> +				   struct list_head *ptp_list)

Personally I'd name these something like filter_list rather than
 ptp_list, but no need to respin just for that.