From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Song Bao Hua (Barry Song)" Date: Wed, 25 Nov 2020 18:22:24 +0000 Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Message-Id: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> List-Id: References: <20201125135535.1880307-1-colin.king@canonical.com> In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Christoph Hellwig , Marek Szyprowski , Robin Murphy , "iommu@lists.linux-foundation.org" Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ29saW4gS2luZyBbbWFp bHRvOmNvbGluLmtpbmdAY2Fub25pY2FsLmNvbV0NCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVy IDI2LCAyMDIwIDI6NTYgQU0NCj4gVG86IFNvbmcgQmFvIEh1YSAoQmFycnkgU29uZykgPHNvbmcu YmFvLmh1YUBoaXNpbGljb24uY29tPjsgQ2hyaXN0b3BoDQo+IEhlbGx3aWcgPGhjaEBsc3QuZGU+ OyBNYXJlayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Ow0KPiBSb2JpbiBN dXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPjsgaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlv bi5vcmcNCj4gQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5l bEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogW1BBVENIXSBkbWEtbWFwcGluZzogZml4IGFu IHVuaW5pdGlhbGl6ZWQgcG9pbnRlciByZWFkIGR1ZSB0byB0eXBvIGluDQo+IGFyZ3AgYXNzaWdu bWVudA0KPiANCj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNv bT4NCj4gDQo+IFRoZSBhc3NpZ25tZW50IG9mIGFyZ3AgaXMgY3VycmVudGx5IHVzaW5nIGFyZ3Ag YXMgdGhlIHNvdXJjZSBiZWNhdXNlIG9mDQo+IGEgdHlwby4gRml4IHRoaXMgYnkgYXNzaWduaW5n IGl0IHRoZSB2YWx1ZSBwYXNzZWQgaW4gYXJnIGluc3RlYWQuDQo+IA0KPiBBZGRyZXNzZXMtQ292 ZXJpdHk6ICgiVW5pbml0aWFsaXplZCBwb2ludGVyIHJlYWQiKQ0KPiBGaXhlczogYmZkMmRlZmVk OTRkICgiZG1hLW1hcHBpbmc6IGFkZCBiZW5jaG1hcmsgc3VwcG9ydCBmb3Igc3RyZWFtaW5nDQo+ IERNQSBBUElzIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdA Y2Fub25pY2FsLmNvbT4NCg0KQWNrZWQtYnk6IEJhcnJ5IFNvbmcgPHNvbmcuYmFvLmh1YUBoaXNp bGljb24uY29tPg0KDQo+IC0tLQ0KPiAga2VybmVsL2RtYS9tYXBfYmVuY2htYXJrLmMgfCAyICst DQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYyBiL2tlcm5lbC9kbWEvbWFw X2JlbmNobWFyay5jDQo+IGluZGV4IGNhNjE2YjY2NGY3Mi4uZTFlMzc2MDNkMDFiIDEwMDY0NA0K PiAtLS0gYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYw0KPiArKysgYi9rZXJuZWwvZG1hL21h cF9iZW5jaG1hcmsuYw0KPiBAQCAtMTkyLDcgKzE5Miw3IEBAIHN0YXRpYyBsb25nIG1hcF9iZW5j aG1hcmtfaW9jdGwoc3RydWN0IGZpbGUgKmZpbGUsDQo+IHVuc2lnbmVkIGludCBjbWQsDQo+ICAJ CXVuc2lnbmVkIGxvbmcgYXJnKQ0KPiAgew0KPiAgCXN0cnVjdCBtYXBfYmVuY2htYXJrX2RhdGEg Km1hcCA9IGZpbGUtPnByaXZhdGVfZGF0YTsNCj4gLQl2b2lkIF9fdXNlciAqYXJncCA9ICh2b2lk IF9fdXNlciAqKWFyZ3A7DQo+ICsJdm9pZCBfX3VzZXIgKmFyZ3AgPSAodm9pZCBfX3VzZXIgKilh cmc7DQo+ICAJdTY0IG9sZF9kbWFfbWFzazsNCj4gDQo+ICAJaW50IHJldDsNCj4gLS0NCj4gMi4y OS4yDQoNClRoYW5rcw0KQmFycnkNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0E7C56202 for ; Wed, 25 Nov 2020 18:22:39 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4B34206CA for ; Wed, 25 Nov 2020 18:22:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4B34206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2114686B7A; Wed, 25 Nov 2020 18:22:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MR3QxJO9z4Dv; Wed, 25 Nov 2020 18:22:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8E10E86B70; Wed, 25 Nov 2020 18:22:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6D24BC0891; Wed, 25 Nov 2020 18:22:36 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 70256C0052 for ; Wed, 25 Nov 2020 18:22:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5ED118761D for ; Wed, 25 Nov 2020 18:22:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h57lMcCr0-By for ; Wed, 25 Nov 2020 18:22:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2B18D875F2 for ; Wed, 25 Nov 2020 18:22:31 +0000 (UTC) Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ch8Nr1jqjzVfv2; Thu, 26 Nov 2020 02:21:48 +0800 (CST) Received: from dggemi711-chm.china.huawei.com (10.3.20.110) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 26 Nov 2020 02:22:24 +0800 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by dggemi711-chm.china.huawei.com (10.3.20.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 26 Nov 2020 02:22:24 +0800 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.1913.007; Thu, 26 Nov 2020 02:22:24 +0800 From: "Song Bao Hua (Barry Song)" To: Colin King , Christoph Hellwig , Marek Szyprowski , Robin Murphy , "iommu@lists.linux-foundation.org" Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Thread-Topic: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Thread-Index: AQHWwzK8QvyQYoZZJ0ueAMVQnzAXH6nZJ9kw Date: Wed, 25 Nov 2020 18:22:24 +0000 Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> References: <20201125135535.1880307-1-colin.king@canonical.com> In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.202.201] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: Thursday, November 26, 2020 2:56 AM > To: Song Bao Hua (Barry Song) ; Christoph > Hellwig ; Marek Szyprowski ; > Robin Murphy ; iommu@lists.linux-foundation.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in > argp assignment > > From: Colin Ian King > > The assignment of argp is currently using argp as the source because of > a typo. Fix this by assigning it the value passed in arg instead. > > Addresses-Coverity: ("Uninitialized pointer read") > Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming > DMA APIs") > Signed-off-by: Colin Ian King Acked-by: Barry Song > --- > kernel/dma/map_benchmark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c > index ca616b664f72..e1e37603d01b 100644 > --- a/kernel/dma/map_benchmark.c > +++ b/kernel/dma/map_benchmark.c > @@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file, > unsigned int cmd, > unsigned long arg) > { > struct map_benchmark_data *map = file->private_data; > - void __user *argp = (void __user *)argp; > + void __user *argp = (void __user *)arg; > u64 old_dma_mask; > > int ret; > -- > 2.29.2 Thanks Barry _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FF5C56202 for ; Wed, 25 Nov 2020 18:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 103492075A for ; Wed, 25 Nov 2020 18:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733050AbgKYSWc (ORCPT ); Wed, 25 Nov 2020 13:22:32 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2072 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731317AbgKYSWb (ORCPT ); Wed, 25 Nov 2020 13:22:31 -0500 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ch8Nr1jqjzVfv2; Thu, 26 Nov 2020 02:21:48 +0800 (CST) Received: from dggemi711-chm.china.huawei.com (10.3.20.110) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 26 Nov 2020 02:22:24 +0800 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by dggemi711-chm.china.huawei.com (10.3.20.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 26 Nov 2020 02:22:24 +0800 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.1913.007; Thu, 26 Nov 2020 02:22:24 +0800 From: "Song Bao Hua (Barry Song)" To: Colin King , Christoph Hellwig , Marek Szyprowski , Robin Murphy , "iommu@lists.linux-foundation.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Thread-Topic: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Thread-Index: AQHWwzK8QvyQYoZZJ0ueAMVQnzAXH6nZJ9kw Date: Wed, 25 Nov 2020 18:22:24 +0000 Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> References: <20201125135535.1880307-1-colin.king@canonical.com> In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.202.201] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ29saW4gS2luZyBbbWFp bHRvOmNvbGluLmtpbmdAY2Fub25pY2FsLmNvbV0NCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVy IDI2LCAyMDIwIDI6NTYgQU0NCj4gVG86IFNvbmcgQmFvIEh1YSAoQmFycnkgU29uZykgPHNvbmcu YmFvLmh1YUBoaXNpbGljb24uY29tPjsgQ2hyaXN0b3BoDQo+IEhlbGx3aWcgPGhjaEBsc3QuZGU+ OyBNYXJlayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Ow0KPiBSb2JpbiBN dXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPjsgaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlv bi5vcmcNCj4gQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5l bEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogW1BBVENIXSBkbWEtbWFwcGluZzogZml4IGFu IHVuaW5pdGlhbGl6ZWQgcG9pbnRlciByZWFkIGR1ZSB0byB0eXBvIGluDQo+IGFyZ3AgYXNzaWdu bWVudA0KPiANCj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNv bT4NCj4gDQo+IFRoZSBhc3NpZ25tZW50IG9mIGFyZ3AgaXMgY3VycmVudGx5IHVzaW5nIGFyZ3Ag YXMgdGhlIHNvdXJjZSBiZWNhdXNlIG9mDQo+IGEgdHlwby4gRml4IHRoaXMgYnkgYXNzaWduaW5n IGl0IHRoZSB2YWx1ZSBwYXNzZWQgaW4gYXJnIGluc3RlYWQuDQo+IA0KPiBBZGRyZXNzZXMtQ292 ZXJpdHk6ICgiVW5pbml0aWFsaXplZCBwb2ludGVyIHJlYWQiKQ0KPiBGaXhlczogYmZkMmRlZmVk OTRkICgiZG1hLW1hcHBpbmc6IGFkZCBiZW5jaG1hcmsgc3VwcG9ydCBmb3Igc3RyZWFtaW5nDQo+ IERNQSBBUElzIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdA Y2Fub25pY2FsLmNvbT4NCg0KQWNrZWQtYnk6IEJhcnJ5IFNvbmcgPHNvbmcuYmFvLmh1YUBoaXNp bGljb24uY29tPg0KDQo+IC0tLQ0KPiAga2VybmVsL2RtYS9tYXBfYmVuY2htYXJrLmMgfCAyICst DQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYyBiL2tlcm5lbC9kbWEvbWFw X2JlbmNobWFyay5jDQo+IGluZGV4IGNhNjE2YjY2NGY3Mi4uZTFlMzc2MDNkMDFiIDEwMDY0NA0K PiAtLS0gYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYw0KPiArKysgYi9rZXJuZWwvZG1hL21h cF9iZW5jaG1hcmsuYw0KPiBAQCAtMTkyLDcgKzE5Miw3IEBAIHN0YXRpYyBsb25nIG1hcF9iZW5j aG1hcmtfaW9jdGwoc3RydWN0IGZpbGUgKmZpbGUsDQo+IHVuc2lnbmVkIGludCBjbWQsDQo+ICAJ CXVuc2lnbmVkIGxvbmcgYXJnKQ0KPiAgew0KPiAgCXN0cnVjdCBtYXBfYmVuY2htYXJrX2RhdGEg Km1hcCA9IGZpbGUtPnByaXZhdGVfZGF0YTsNCj4gLQl2b2lkIF9fdXNlciAqYXJncCA9ICh2b2lk IF9fdXNlciAqKWFyZ3A7DQo+ICsJdm9pZCBfX3VzZXIgKmFyZ3AgPSAodm9pZCBfX3VzZXIgKilh cmc7DQo+ICAJdTY0IG9sZF9kbWFfbWFzazsNCj4gDQo+ICAJaW50IHJldDsNCj4gLS0NCj4gMi4y OS4yDQoNClRoYW5rcw0KQmFycnkNCg0K