From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E771C433DB for ; Fri, 19 Feb 2021 17:26:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B32364E67 for ; Fri, 19 Feb 2021 17:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B32364E67 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD9Xp-0004RU-DR for qemu-devel@archiver.kernel.org; Fri, 19 Feb 2021 12:26:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9WV-0003j7-2W for qemu-devel@nongnu.org; Fri, 19 Feb 2021 12:24:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:58762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9WT-0001EP-Fa for qemu-devel@nongnu.org; Fri, 19 Feb 2021 12:24:58 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 58833B115; Fri, 19 Feb 2021 17:24:54 +0000 (UTC) Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/ To: Paolo Bonzini , Thomas Huth References: From: Claudio Fontana Message-ID: <1b63451f-3188-2edb-63ea-03fe0abb3bbf@suse.de> Date: Fri, 19 Feb 2021 18:24:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/19/21 5:04 PM, Paolo Bonzini wrote: > On 19/02/21 14:30, Thomas Huth wrote: >>> But how could tests see this? >> >> The test are generic, not target-specific code, so they can not see >> things like NEED_CPU_H, of course. >> >> But CONFIG_TCG seems to be defined in config-host.h, so you should be >> able to use that define, shouldn't you? > > Yes, CONFIG_TCG is defined in config_hsot just for that reason: > > tcg_arch = config_host['ARCH'] > if not get_option('tcg').disabled() > ... > accelerators += 'CONFIG_TCG' > config_host += { 'CONFIG_TCG': 'y' } > endif > > It's ugly, but I kept it that way when moving accelerator configuration > to Meson. > > Paolo > understood, thanks a lot for this important piece of the puzzle! Ciao, Claudio