Re: Patch "powerpc: do not build ppc_save_regs.o always" has been added to the 6.15-stable tree

[Jiri Slaby <jirislaby@kernel.org>]

On 10. 06. 25, 13:56, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>      powerpc: do not build ppc_save_regs.o always
> 
> to the 6.15-stable tree which can be found at:
>      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Please drop this from all trees. It was correctly broken. The whole if 
was removed later by 93bd4a80efeb521314485a06d8c21157240497bb.

> The filename of the patch is:
>       powerpc-do-not-build-ppc_save_regs.o-always.patch
> and it can be found in the queue-6.15 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 242c2ba3f16d92cd81c309725550f6c723833ae3
> Author: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Date:   Thu Apr 17 12:53:05 2025 +0200
> 
>      powerpc: do not build ppc_save_regs.o always
>      
>      [ Upstream commit 497b7794aef03d525a5be05ae78dd7137c6861a5 ]
>      
>      The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the
>      conditions to enable the build of ppc_save_regs.o. But it failed to do
>      so, in fact. The commit omitted to add a dollar sign.
>      
>      Therefore, ppc_save_regs.o is built always these days (as
>      "(CONFIG_PPC_BOOK3S)" is never an empty string).
>      
>      Fix this by adding the missing dollar sign.
>      
>      Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>      Fixes: fc2a5a6161a2 ("powerpc/64s: ppc_save_regs is now needed for all 64s builds")
>      Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
>      Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>      Link: https://patch.msgid.link/20250417105305.397128-1-jirislaby@kernel.org
>      Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 6ac621155ec3c..0c26b2412d173 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -160,7 +160,7 @@ endif
>   
>   obj64-$(CONFIG_PPC_TRANSACTIONAL_MEM)	+= tm.o
>   
> -ifneq ($(CONFIG_XMON)$(CONFIG_KEXEC_CORE)(CONFIG_PPC_BOOK3S),)
> +ifneq ($(CONFIG_XMON)$(CONFIG_KEXEC_CORE)$(CONFIG_PPC_BOOK3S),)
>   obj-y				+= ppc_save_regs.o
>   endif
>   


-- 
js
suse labs