Re: [PATCH 1/9] rv: Fix __user specifier usage in extract_params()

[Wen Yang <wen.yang@linux.dev>]

Correct.  __user annotates the pointer type, not the stack copy.

Reviewed-by: Wen Yang <wen.yang@linux.dev>


On 5/12/26 22:02, Gabriele Monaco wrote:
> The attributes variables extracted from syscalls in the helper are both
> defined with the __user specifier although only the actual pointer to
> user data should be marked.
> 
> Remove the __user specifier from attr.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604150820.Ny143u6X-lkp@intel.com
> Fixes: b133207deb72 ("rv: Add nomiss deadline monitor")
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
> ---
>   kernel/trace/rv/monitors/deadline/deadline.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/rv/monitors/deadline/deadline.h b/kernel/trace/rv/monitors/deadline/deadline.h
> index 0bbfd2543329..78fca873d61e 100644
> --- a/kernel/trace/rv/monitors/deadline/deadline.h
> +++ b/kernel/trace/rv/monitors/deadline/deadline.h
> @@ -95,7 +95,8 @@ static inline u8 get_server_type(struct task_struct *tsk)
>   static inline int extract_params(struct pt_regs *regs, long id, pid_t *pid_out)
>   {
>   	size_t size = offsetofend(struct sched_attr, sched_flags);
> -	struct sched_attr __user *uattr, attr;
> +	struct sched_attr __user *uattr;
> +	struct sched_attr attr;
>   	int new_policy = -1, ret;
>   	unsigned long args[6];
>